Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5341b62 authored by Junyeong Bak's avatar Junyeong Bak Committed by Tyler Gunn
Browse files

Add missing break statement 



Changed to enhanced switch expressions to prevent missing break statement.

Bug: 358147471
Test: Crash InCallService
Flag: EXEMPT bugfix
Signed-off-by: default avatarJunyeong Bak <junyeong.bak@samsung.com>
(cherry picked from https://partner-android-review.googlesource.com/q/commit:22a9fa582e401f7a5ad0febbfef883ea5a1ce3b7)
Merged-In: I7e74dc59d0a7ca77d5eb57fcb58341644348cadc
Change-Id: I7e74dc59d0a7ca77d5eb57fcb58341644348cadc
parent 8d50b8d7

src/com/android/server/telecom/ui/NotificationChannelManager.java

+14 −13
Original line number Diff line number Diff line
@@ -83,61 +83,62 @@ public class NotificationChannelManager { 
        boolean vibration = false;

        Uri sound = silentRingtone;

        switch (channelId) {

            case CHANNEL_ID_INCOMING_CALLS:

            case CHANNEL_ID_INCOMING_CALLS -> {

                name = context.getText(R.string.notification_channel_incoming_call);

                importance = NotificationManager.IMPORTANCE_MAX;

                canShowBadge = false;

                lights = true;

                vibration = false;

                sound = silentRingtone;

                break;

            case CHANNEL_ID_MISSED_CALLS:

            }

            case CHANNEL_ID_MISSED_CALLS -> {

                name = context.getText(R.string.notification_channel_missed_call);

                importance = NotificationManager.IMPORTANCE_DEFAULT;

                canShowBadge = true;

                lights = true;

                vibration = true;

                sound = silentRingtone;

                break;

            case CHANNEL_ID_CALL_BLOCKING:

            }

            case CHANNEL_ID_CALL_BLOCKING -> {

                name = context.getText(R.string.notification_channel_call_blocking);

                importance = NotificationManager.IMPORTANCE_LOW;

                canShowBadge = false;

                lights = false;

                vibration = false;

                sound = null;

                break;

            case CHANNEL_ID_AUDIO_PROCESSING:

            }

            case CHANNEL_ID_AUDIO_PROCESSING -> {

                name = context.getText(R.string.notification_channel_background_calls);

                importance = NotificationManager.IMPORTANCE_LOW;

                canShowBadge = false;

                lights = false;

                vibration = false;

                sound = null;

                break;

            case CHANNEL_ID_DISCONNECTED_CALLS:

            }

            case CHANNEL_ID_DISCONNECTED_CALLS -> {

                name = context.getText(R.string.notification_channel_disconnected_calls);

                importance = NotificationManager.IMPORTANCE_DEFAULT;

                canShowBadge = true;

                lights = true;

                vibration = true;

                sound = silentRingtone;

                break;

            case CHANNEL_ID_IN_CALL_SERVICE_CRASH:

            }

            case CHANNEL_ID_IN_CALL_SERVICE_CRASH -> {

                name = context.getText(R.string.notification_channel_in_call_service_crash);

                importance = NotificationManager.IMPORTANCE_DEFAULT;

                canShowBadge = true;

                lights = true;

                vibration = true;

                sound = null;

            case CHANNEL_ID_CALL_STREAMING:

            }

            case CHANNEL_ID_CALL_STREAMING -> {

                name = context.getText(R.string.notification_channel_call_streaming);

                importance = NotificationManager.IMPORTANCE_DEFAULT;

                canShowBadge = false;

                lights = false;

                vibration = false;

                sound = null;

                break;

            }

        }



        NotificationChannel channel = new NotificationChannel(channelId, name, importance);