Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba422963 authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Improve headset media button logging in Telecom. 

Improve logs when media button presses are raised to Telecom.  We've seen
some issues with this behavior and are hampered by the log level of this
code being debug-only.

Test: Manual testing to verify log presence
Bug: 377845864
Flag: NONE logs only change
Change-Id: Ib2177f2c01686e9400f0dd93afee214bb6d3c852
parent 8deef8d2

src/com/android/server/telecom/CallsManager.java

+4 −1
Original line number Diff line number Diff line
@@ -4426,12 +4426,14 @@ public class CallsManager extends Call.ListenerBase 
                        return true;

                    }

                } else {

                    Log.addEvent(ringingCall, LogUtils.Events.INFO,

                            "media btn short press - answer call.");

                    answerCall(ringingCall, VideoProfile.STATE_AUDIO_ONLY);

                    return true;

                }

            } else if (HeadsetMediaButton.LONG_PRESS == type) {

                if (ringingCall != null) {

                    Log.addEvent(getForegroundCall(),

                    Log.addEvent(ringingCall,

                            LogUtils.Events.INFO, "media btn long press - reject");

                    ringingCall.reject(false, null);

                } else {
@@ -4452,6 +4454,7 @@ public class CallsManager extends Call.ListenerBase 
                return true;

            }

        }

        Log.i(this, "onMediaButton: type=%d; no active calls", type);

        return false;

    }

src/com/android/server/telecom/HeadsetMediaButton.java

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ public class HeadsetMediaButton extends CallsManagerListenerBase { 
                if ((event != null) && ((event.getKeyCode() == KeyEvent.KEYCODE_HEADSETHOOK) ||

                        (event.getKeyCode() == KeyEvent.KEYCODE_MEDIA_PLAY_PAUSE))) {

                    synchronized (mLock) {

                        Log.v(this, "SessionCallback: HEADSETHOOK/MEDIA_PLAY_PAUSE");

                        Log.i(this, "onMediaButton: event=%s", event);

                        boolean consumed = handleCallMediaButton(event);

                        Log.v(this, "==> handleCallMediaButton(): consumed = %b.", consumed);

                        return consumed;