Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b58abbb5 authored by Thomas Stuart's avatar Thomas Stuart
Browse files

seperating callback changes 

After some discussion amongst Telecom and an API council member, the
better design decision is to break up previous CallEventCallback into
two seperate callbacks.

The reason being, there is one set of callbacks that require the
client to complete a Consumer and another set of callbacks that only
provide event updates.

By making this change, the API surface becomes cleaner and should
eliminate some confusion.

bug: 268098087
Test: CTS
Change-Id: Ib9dce46096bd26b33221501c3ac8240670ca27ab
parent 9e970ecb

testapps/transactionalVoipApp/src/com/android/server/telecom/transactionalVoipApp/MyVoipCall.java

+2 −4
Original line number Diff line number Diff line
@@ -16,8 +16,7 @@ 


package com.android.server.telecom.transactionalVoipApp;





import android.telecom.CallAudioState;

import android.telecom.CallControlCallback;

import android.telecom.CallEndpoint;

import android.telecom.CallControl;

import android.telecom.CallEventCallback;
@@ -28,7 +27,7 @@ import androidx.annotation.NonNull; 


import java.util.function.Consumer;



public class MyVoipCall implements CallEventCallback {

public class MyVoipCall implements CallControlCallback, CallEventCallback {



    private static final String TAG = "MyVoipCall";

    private final String mCallId;
@@ -99,6 +98,5 @@ public class MyVoipCall implements CallEventCallback { 


    @Override

    public void onMuteStateChanged(boolean isMuted) {



    }

}

testapps/transactionalVoipApp/src/com/android/server/telecom/transactionalVoipApp/VoipAppMainActivity.java

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ public class VoipAppMainActivity extends Activity { 


                    }

                },

                call);

                call, call);

    }



    private void setCallActive(MyVoipCall call) {