Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3c8dc45 authored by Grant Menke's avatar Grant Menke
Browse files

Increased logging for calls that are created but never added. 

Increased and standardized Telecom logging procedures for calls that are crewated but never successfully added to CallsManager in order to make debugging easier in the future.

Bug: 269467189
Test: N/A as change is logging only
Change-Id: Ia4cf26650626fb45d09b5668354becc9e1f81b1a
parent dceca2ec

src/com/android/server/telecom/Call.java

+4 −0
Original line number Diff line number Diff line
@@ -2397,6 +2397,8 @@ public class Call implements CreateConnectionResponse, EventManager.Loggable, 


    @Override

    public void handleCreateConferenceFailure(DisconnectCause disconnectCause) {

        Log.i(this, "handleCreateConferenceFailure; callid=%s, disconnectCause=%s",

                getId(), disconnectCause);

        clearConnectionService();

        setDisconnectCause(disconnectCause);

        mCallsManager.markCallAsDisconnected(this, disconnectCause);
@@ -2417,6 +2419,8 @@ public class Call implements CreateConnectionResponse, EventManager.Loggable, 


    @Override

    public void handleCreateConnectionFailure(DisconnectCause disconnectCause) {

        Log.i(this, "handleCreateConnectionFailure; callid=%s, disconnectCause=%s",

                getId(), disconnectCause);

        clearConnectionService();

        setDisconnectCause(disconnectCause);

        mCallsManager.markCallAsDisconnected(this, disconnectCause);

src/com/android/server/telecom/CallsManager.java

+3 −3
Original line number Diff line number Diff line
@@ -728,8 +728,7 @@ public class CallsManager extends Call.ListenerBase 


    @Override

    public void onFailedOutgoingCall(Call call, DisconnectCause disconnectCause) {

        Log.v(this, "onFailedOutgoingCall, call: %s", call);



        Log.i(this, "onFailedOutgoingCall for call %s", call);

        markCallAsRemoved(call);

    }
@@ -984,14 +983,15 @@ public class CallsManager extends Call.ListenerBase 


    @Override

    public void onFailedIncomingCall(Call call) {

        Log.i(this, "onFailedIncomingCall for call %s", call);

        setCallState(call, CallState.DISCONNECTED, "failed incoming call");

        call.removeListener(this);

    }



    @Override

    public void onSuccessfulUnknownCall(Call call, int callState) {

        setCallState(call, callState, "successful unknown call");

        Log.i(this, "onSuccessfulUnknownCall for call %s", call);

        setCallState(call, callState, "successful unknown call");

        addCall(call);

    }

src/com/android/server/telecom/ConnectionServiceWrapper.java

+1 −1
Original line number Diff line number Diff line
@@ -1597,7 +1597,7 @@ public class ConnectionServiceWrapper extends ServiceBinder implements 
            public void onSuccess() {

                String callId = mCallIdMapper.getCallId(call);

                if (callId == null) {

                    Log.w(ConnectionServiceWrapper.this, "Call not present"

                    Log.i(ConnectionServiceWrapper.this, "Call not present"

                            + " in call id mapper, maybe it was aborted before the bind"

                            + " completed successfully?");

                    response.handleCreateConnectionFailure(