Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9028de4 authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Fix breaking telecom tests. 

The Telecom tests had an inappropriate dependency on content provider.
Removing this part of the test ensures that changes to the content
provider no longer breaks Telecom tests.
The AsyncBlockCheckFilterTest performs more valuable validations and it
is not impacted.

Bug: 120684034
Test: Run unit tests
Change-Id: Ic921dad08ecaac8220d225eeddbf2c2b4fa84d8a
parent 4ab4a8a8

tests/src/com/android/server/telecom/tests/TelecomSystemTest.java

+0 −14
Original line number Diff line number Diff line
@@ -864,20 +864,6 @@ public class TelecomSystemTest extends TelecomTestCase { 
        //Wait for/Verify call blocking happened asynchronously

        incomingCallAddedLatch.await(TEST_TIMEOUT, TimeUnit.MILLISECONDS);



        // Do the blocked number check only for non-self-managed calls

        PhoneAccount pa = mTelecomSystem.getPhoneAccountRegistrar()

                .getPhoneAccount(phoneAccountHandle, phoneAccountHandle.getUserHandle());

        if (!pa.hasCapabilities(PhoneAccount.CAPABILITY_SELF_MANAGED)) {

            IContentProvider blockedNumberProvider =

                    mSpyContext.getContentResolver().acquireProvider(

                            BlockedNumberContract.AUTHORITY);

            verify(blockedNumberProvider, timeout(TEST_TIMEOUT)).call(

                    anyString(),

                    eq(BlockedNumberContract.SystemContract.METHOD_SHOULD_SYSTEM_BLOCK_NUMBER),

                    eq(number),

                    isNotNull(Bundle.class));

        }



        // For the case of incoming calls, Telecom connecting the InCall services and adding the

        // Call is triggered by the async completion of the CallerInfoAsyncQuery. Once the Call

        // is added, future interactions as triggered by the ConnectionService, through the various