Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bc474fe authored by Grant Menke's avatar Grant Menke
Browse files

Demote "putExtras failed due to null CS" error to a warning. 

Currently in Telecom, if the ConnectionService is null when we try to add extras to the extras bundle associated with a Call via Call#putExtras, we log a new NPE as an error but the NPE is never actually thrown. Demoting this to a warning log instead of a error log will make this more clear to the triager that this is not the root issue in most cases.

Bug: 325296049
Test: Logging update only
Change-Id: I43f9d316f68651521f47b9d0afc6ed79111c9d42
parent 99505ba0

src/com/android/server/telecom/Call.java

+1 −2
Original line number Diff line number Diff line
@@ -3171,8 +3171,7 @@ public class Call implements CreateConnectionResponse, EventManager.Loggable, 
            } else if (mConnectionService != null) {

                mConnectionService.onExtrasChanged(this, mExtras);

            } else {

                Log.e(this, new NullPointerException(),

                        "putExtras failed due to null CS callId=%s", getId());

                Log.w(this, "putExtras failed due to null CS callId=%s", getId());

            }

        }

    }