Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60e56543 authored by Brad Ebinger's avatar Brad Ebinger
Browse files

When in an ACTIVE call, SELECT_PHONE_ACCOUNT should work across subs 

When a user is on an ACTIVE call on PhoneAccount A, the ACTIVE call
should properly hold when the user selects PhoneAccount B during
PhoneAccount selection.

This change changes the ordering of outgoing calls from
makeRoomForCall->SELECT_PHONE_ACCOUNT to
SELECT_PHONE_ACCOUNT->makeRoomForCall to ensure existing calls
are properly held.

Bug: 417370866
Test: atest CtsTelecomCujTestCases; manual
Flag: com.android.server.telecom.flags.select_phone_account_before_making_room
Change-Id: I627011312594634dc4d9abbb98f0191eac4db3ab
parent 13b32d0a

flags/telecom_calls_manager_flags.aconfig

+11 −0
Original line number Diff line number Diff line
@@ -30,3 +30,14 @@ flag { 
    purpose: PURPOSE_BUGFIX

  }

}



# OWNER=breadley TARGET=25Q3

flag {

  name: "select_phone_account_before_making_room"

  namespace: "telecom"

  description: "Select the PhoneAccount before making room for the call"

  bug: "417370866"

  metadata {

    purpose: PURPOSE_BUGFIX

  }

}

src/com/android/server/telecom/CallsManager.java

+401 −2

File changed.

Preview size limit exceeded, changes collapsed.

src/com/android/server/telecom/callsequencing/CallSequencingController.java

+2 −2
Original line number Diff line number Diff line
@@ -539,7 +539,7 @@ public class CallSequencingController { 
            return transactionFuture;

        }



        Call liveCall = mCallsManager.getFirstCallWithLiveState();

        Call liveCall = mCallsManager.getFirstCallWithLiveState(emergencyCall);

        Log.i(this, "makeRoomForOutgoingEmergencyCall: call = " + emergencyCall

                + " livecall = " + liveCall);
@@ -745,7 +745,7 @@ public class CallSequencingController { 


        // NOTE: If the amount of live calls changes beyond 1, this logic will probably

        // have to change.

        Call liveCall = mCallsManager.getFirstCallWithLiveState();

        Call liveCall = mCallsManager.getFirstCallWithLiveState(call);

        Log.i(this, "makeRoomForOutgoingCall call = " + call + " livecall = " +

                liveCall);

tests/src/com/android/server/telecom/tests/CallSequencingTests.java

+2 −2
Original line number Diff line number Diff line
@@ -675,7 +675,7 @@ public class CallSequencingTests extends TelecomTestCase { 
        when(mCallsManager.hasRingingOrSimulatedRingingCall()).thenReturn(true);

        when(mCallsManager.getRingingOrSimulatedRingingCall()).thenReturn(mRingingCall);

        when(mCallsManager.hasMaximumLiveCalls(mNewCall)).thenReturn(true);

        when(mCallsManager.getFirstCallWithLiveState()).thenReturn(mActiveCall);

        when(mCallsManager.getFirstCallWithLiveState(mNewCall)).thenReturn(mActiveCall);

        when(mCallsManager.hasMaximumOutgoingCalls(mNewCall)).thenReturn(false);

        when(mCallsManager.hasMaximumManagedHoldingCalls(mNewCall)).thenReturn(false);

        when(mCallsManager.canHold(mActiveCall)).thenReturn(true);
@@ -713,7 +713,7 @@ public class CallSequencingTests extends TelecomTestCase { 


    private void setupMakeRoomForOutgoingCallMocks() {

        when(mCallsManager.hasMaximumLiveCalls(mNewCall)).thenReturn(true);

        when(mCallsManager.getFirstCallWithLiveState()).thenReturn(mActiveCall);

        when(mCallsManager.getFirstCallWithLiveState(mNewCall)).thenReturn(mActiveCall);

        setPhoneAccounts(mActiveCall, mNewCall, false);

        when(mActiveCall.isConference()).thenReturn(false);

        when(mCallsManager.hasMaximumOutgoingCalls(mNewCall)).thenReturn(false);