Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53fad3df authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Remove BIND_ALLOW_BACKGROUND_ACTIVITY_STARTS for ConnectionService bind. 

This was added in error as a way to grant InCallServices the ability to
start activities.  This binding code is ONLY used for ConnectionServices.

Test: Run Telecom CTS and unit test suite.
Fixes: 168211626
Change-Id: I75568a4b3827f1fc46f84972703ceed0cb7369be
parent 4f642851

src/com/android/server/telecom/ServiceBinder.java

+1 −2
Original line number Original line Diff line number Diff line
@@ -87,8 +87,7 @@ public abstract class ServiceBinder { 
                ServiceConnection connection = new ServiceBinderConnection(call);

                ServiceConnection connection = new ServiceBinderConnection(call);





                Log.addEvent(call, LogUtils.Events.BIND_CS, mComponentName);

                Log.addEvent(call, LogUtils.Events.BIND_CS, mComponentName);

                final int bindingFlags = Context.BIND_AUTO_CREATE | Context.BIND_FOREGROUND_SERVICE

                final int bindingFlags = Context.BIND_AUTO_CREATE | Context.BIND_FOREGROUND_SERVICE;

                        | Context.BIND_ALLOW_BACKGROUND_ACTIVITY_STARTS;

                final boolean isBound;

                final boolean isBound;

                if (mUserHandle != null) {

                if (mUserHandle != null) {

                    isBound = mContext.bindServiceAsUser(serviceIntent, connection, bindingFlags,

                    isBound = mContext.bindServiceAsUser(serviceIntent, connection, bindingFlags,