Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52bc9cfa authored by Pranav Madapurmath's avatar Pranav Madapurmath
Browse files

Clean up on_call_endpoint_changed_ics_on_connected 

Remove the telecom flag now that it has fully rolled out.

Bug: 409607274
Flag: EXEMPT flag cleanup
Test: atest InCallControllerTests

Change-Id: I259cd6493426ac7bf5e5ec2a48d609fc37244f6b
parent cea6e83a

flags/telecom_incallservice_flags.aconfig

+0 −8
Original line number Diff line number Diff line
@@ -25,14 +25,6 @@ flag { 
  bug: "306395598"

}



# OWNER=pmadapurmath TARGET=24Q4

flag {

  name: "on_call_endpoint_changed_ics_on_connected"

  namespace: "telecom"

  description: "Ensure onCallEndpointChanged is sent to ICS when it connects."

  bug: "348297436"

}



# OWNER=tjstuart TARGET=24Q4

flag {

  name: "do_not_send_call_to_null_ics"

src/com/android/server/telecom/InCallController.java

+2 −4
Original line number Diff line number Diff line
@@ -2660,10 +2660,8 @@ public class InCallController extends CallsManagerListenerBase implements 
        try {

            inCallService.onCallAudioStateChanged(mCallsManager.getAudioState());

            inCallService.onCanAddCallChanged(mCallsManager.canAddCall());

            if (mFeatureFlags.onCallEndpointChangedIcsOnConnected()) {

            inCallService.onCallEndpointChanged(mCallsManager.getCallEndpointController()

                    .getCurrentCallEndpoint());

            }

        } catch (RemoteException ignored) {

        }

        // Don't complete the binding future for non-ui incalls

tests/src/com/android/server/telecom/tests/InCallControllerTests.java

+0 −1
Original line number Diff line number Diff line
@@ -310,7 +310,6 @@ public class InCallControllerTests extends TelecomTestCase { 
                .thenReturn(PackageManager.PERMISSION_DENIED);



        when(mMockCallsManager.getAudioState()).thenReturn(new CallAudioState(false, 0, 0));

        when(mFeatureFlags.onCallEndpointChangedIcsOnConnected()).thenReturn(true);

        when(mMockCallsManager.getCallEndpointController()).thenReturn(mMockCallEndpointController);

        when(mMockCallEndpointController.getCurrentCallEndpoint())

                .thenReturn(new CallEndpoint("Earpiece", 1));