Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 507ab82c authored by Pranav Madapurmath's avatar Pranav Madapurmath
Browse files

Resolve flaky call sequencing unit tests 

With the recent changes made to the ECC logic for call sequencing,
additional waiting needs to be included for the reject verification.
This will resolve the flakiness found around these tests.

Bug: 401736961
Flag: EXEMPT test fix
Test: atest CallSequencingTests
Change-Id: I8ab0fb6b371bc5414124a9a4fd50a829b369479c
parent 94df0e5e

tests/src/com/android/server/telecom/tests/CallSequencingTests.java

+2 −2
Original line number Diff line number Diff line
@@ -496,7 +496,7 @@ public class CallSequencingTests extends TelecomTestCase { 
        setupMakeRoomForOutgoingEmergencyCallMocks();



        CompletableFuture<Boolean> future = mController.makeRoomForOutgoingCall(true, mNewCall);

        verify(mRingingCall)

        verify(mRingingCall, timeout(SEQUENCING_TIMEOUT_MS))

                .reject(anyBoolean(), eq(null), anyString());

        verify(mActiveCall, timeout(SEQUENCING_TIMEOUT_MS)).hold(anyString());

        assertTrue(waitForFutureResult(future, false));
@@ -512,7 +512,7 @@ public class CallSequencingTests extends TelecomTestCase { 
        setupMakeRoomForOutgoingEmergencyCallMocks();



        CompletableFuture<Boolean> future = mController.makeRoomForOutgoingCall(true, mNewCall);

        verify(mRingingCall)

        verify(mRingingCall, timeout(SEQUENCING_TIMEOUT_MS))

                .reject(anyBoolean(), eq(null), anyString());

        verify(mActiveCall, timeout(SEQUENCING_TIMEOUT_MS)).hold(anyString());

        assertTrue(waitForFutureResult(future, false));