Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4031fda3 authored by Grace Jia's avatar Grace Jia Committed by Android (Google) Code Review
Browse files

Revert "[conflict] Fix security vulnerability issue for multi user call... 

Revert "[conflict] Fix security vulnerability issue for multi user call redirections. am: 799347b6 am: 7912558a am: a1797f2b am: c1a8b0a5"

This reverts commit 010ddaad.

Reason for revert: cl break the build

Change-Id: Ic8368869ef80ea679cc6e92cdd6703015b62b38f
parent 010ddaad

src/com/android/server/telecom/CallsManager.java

+0 −8
Original line number Diff line number Diff line
@@ -2121,11 +2121,7 @@ public class CallsManager extends Call.ListenerBase 
                && !phoneAccount.hasCapabilities(PhoneAccount.CAPABILITY_MULTI_USER)) {

            // Check if the phoneAccountHandle belongs to the current user

            if (phoneAccountHandle != null &&

<<<<<<< TARGET BRANCH (d96a24 Merge "Fix hearing aid device audio route switch issue.")

                    !phoneAccountHandle.getUserHandle().equals(mCurrentUserHandle)) {

=======

                    !phoneAccountHandle.getUserHandle().equals(call.getInitiatingUser())) {

>>>>>>> SOURCE BRANCH (c1a8b0 Fix security vulnerability issue for multi user call redirec)

                phoneAccountHandle = null;

            }

        }
@@ -2166,11 +2162,7 @@ public class CallsManager extends Call.ListenerBase 
            Log.w(this, "onCallRedirectionComplete: phoneAccountHandle is unavailable");

            endEarly = true;

            disconnectReason = "Unavailable phoneAccountHandle from Call Redirection Service";

<<<<<<< TARGET BRANCH (d96a24 Merge "Fix hearing aid device audio route switch issue.")

        } else if (isEmergencyNumber) {

=======

        } else if (isPotentialEmergencyNumber) {

>>>>>>> SOURCE BRANCH (c1a8b0 Fix security vulnerability issue for multi user call redirec)

            Log.w(this, "onCallRedirectionComplete: emergency number %s is redirected from Call"

                    + " Redirection Service", handle.getSchemeSpecificPart());

            endEarly = true;

tests/src/com/android/server/telecom/tests/CallsManagerTest.java

+0 −3
Original line number Diff line number Diff line
@@ -1713,7 +1713,6 @@ public class CallsManagerTest extends TelecomTestCase { 
                new UserHandle(90210)));

    }



<<<<<<< TARGET BRANCH (d96a24 Merge "Fix hearing aid device audio route switch issue.")

    /**

     * Verifies that if a {@link android.telecom.CallScreeningService} app can properly request

     * notification show for rejected calls.
@@ -1751,8 +1750,6 @@ public class CallsManagerTest extends TelecomTestCase { 
        assertEquals(CallState.DISCONNECTED, newCall.getState());

    }



=======

>>>>>>> SOURCE BRANCH (c1a8b0 Fix security vulnerability issue for multi user call redirec)

    @SmallTest

    @Test

    public void testCrossUserCallRedirectionEndEarlyForIncapablePhoneAccount() {