Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b0facb2 authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Disable "crashed dialer" message when Dialer doesn't implement ICS. 

When Dialer doesn't implement the InCallService, removing the "crashed"
message we're showing.  Since the role does not currently require the
ICS implementation, we should not show the notification when one is not
present.

Fixes: 159650984
Test: Re-ran unit tests; verify all pass.
Test: Verify using 3p app that no "dialer crash" message is shown.
Change-Id: I4df10e337d2895dcfb3b010fd1e53aff657cc6eb
parent 920b2aec

src/com/android/server/telecom/InCallController.java

+6 −4
Original line number Diff line number Diff line
@@ -1324,10 +1324,12 @@ public class InCallController extends CallsManagerListenerBase { 
                (systemPackageName != null && systemPackageName.equals(packageName))

                ? getInCallServiceComponent(packageName, IN_CALL_SERVICE_TYPE_SYSTEM_UI)

                : getInCallServiceComponent(packageName, IN_CALL_SERVICE_TYPE_DIALER_UI);

        /* TODO: in Android 12 re-enable this an InCallService is required by the dialer role.

            if (packageName != null && defaultDialerComponent == null) {

                // The in call service of default phone app is disabled, send notification.

                sendCrashedInCallServiceNotification(packageName);

            }

        */

        return defaultDialerComponent;

    }