Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e8cc100 authored by Wink Saville's avatar Wink Saville Committed by Natiq Ahmed
Browse files

Change subId to int from long

Also remove an unused method.

Change-Id: Idae6335e63e7b1e4e714bc17e71b1a4705e38474
parent ec7b3760
Loading
Loading
Loading
Loading
+4 −15
Original line number Diff line number Diff line
@@ -118,26 +118,15 @@ public final class PhoneAccountRegistrar {
        read();
    }

    /**
     * Retrieves the phone account id for a given subscription id if it exists. Subscription ids
     * apply only to PSTN/SIM card phone accounts so all other accounts should not have a
     * subscription id.
     * @param subscriptionId The subscription id for which to construct the phone account id
     * @return The string representing the phone account id for the subscription id.
     */
    public String getPhoneAccountIdForSubscriptionId(long subscriptionId) {
        return String.valueOf(subscriptionId);
    }

    /**
     * Retrieves the subscription id for a given phone account if it exists. Subscription ids
     * apply only to PSTN/SIM card phone accounts so all other accounts should not have a
     * subscription id.
     * @param accountHandle The handle for the phone account for which to retrieve the
     * subscription id.
     * @return The value of the subscription id (long) or -1 if it does not exist or is not valid.
     * @return The value of the subscription id or -1 if it does not exist or is not valid.
     */
    public long getSubscriptionIdForPhoneAccount(PhoneAccountHandle accountHandle) {
    public int getSubscriptionIdForPhoneAccount(PhoneAccountHandle accountHandle) {
        PhoneAccount account = getPhoneAccount(accountHandle);
        if (account == null || !account.hasCapabilities(PhoneAccount.CAPABILITY_SIM_SUBSCRIPTION) ||
                !TextUtils.isDigitsOnly(accountHandle.getId())) {
@@ -145,7 +134,7 @@ public final class PhoneAccountRegistrar {
            // numbers can be subscription id
            return SubscriptionManager.INVALID_SUBSCRIPTION_ID;
        }
        return Long.parseLong(accountHandle.getId());
        return Integer.parseInt(accountHandle.getId());
    }

    /**
@@ -520,7 +509,7 @@ public final class PhoneAccountRegistrar {
    }

    public boolean isVoiceMailNumber(PhoneAccountHandle accountHandle, String number) {
        long subId = getSubscriptionIdForPhoneAccount(accountHandle);
        int subId = getSubscriptionIdForPhoneAccount(accountHandle);
        return PhoneNumberUtils.isVoiceMailNumber(subId, number);
    }