Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ceb5a12 authored by Santos Cordon's avatar Santos Cordon Committed by Jay Shrauner
Browse files

Add permission to CONNECTION_MANAGER PhoneAccount registration. 

We need to add a system-level permission for registering PhoneAccounts
to prevent third party apps from registering and being able to
control the call.

Bug: 18100571
Change-Id: I06de9311620b271904babc78f23faff90a15e1a9
parent cf1b37c6

AndroidManifest.xml

+5 −0
Original line number Diff line number Diff line
@@ -45,6 +45,11 @@ 
            android:label="Register CALL_PROVIDER or SIM_SUBSCRIPTION PhoneAccount"

            android:protectionLevel="signature"/>



    <permission

            android:name="com.android.server.telecom.permission.REGISTER_CONNECTION_MANAGER"

            android:label="Register CONNECTION_MANAGER PhoneAccount"

            android:protectionLevel="signature"/>



    <permission

            android:name="android.permission.BROADCAST_CALLLOG_INFO"

            android:label="Broadcast the call type/duration information"

src/com/android/server/telecom/TelecomServiceImpl.java

+9 −0
Original line number Diff line number Diff line
@@ -52,6 +52,8 @@ import java.util.List; 
public class TelecomServiceImpl extends ITelecomService.Stub {

    private static final String REGISTER_PROVIDER_OR_SUBSCRIPTION =

            "com.android.server.telecom.permission.REGISTER_PROVIDER_OR_SUBSCRIPTION";

    private static final String REGISTER_CONNECTION_MANAGER =

            "com.android.server.telecom.permission.REGISTER_CONNECTION_MANAGER";



    /** The context. */

    private Context mContext;
@@ -295,6 +297,9 @@ public class TelecomServiceImpl extends ITelecomService.Stub { 
                account.hasCapabilities(PhoneAccount.CAPABILITY_SIM_SUBSCRIPTION)) {

                enforceRegisterProviderOrSubscriptionPermission();

            }

            if (account.hasCapabilities(PhoneAccount.CAPABILITY_CONNECTION_MANAGER)) {

                enforceRegisterConnectionManagerPermission();

            }



            mPhoneAccountRegistrar.registerPhoneAccount(account);

        } catch (Exception e) {
@@ -573,6 +578,10 @@ public class TelecomServiceImpl extends ITelecomService.Stub { 
        enforcePermission(REGISTER_PROVIDER_OR_SUBSCRIPTION);

    }



    private void enforceRegisterConnectionManagerPermission() {

        enforcePermission(REGISTER_CONNECTION_MANAGER);

    }



    private void enforceReadPermission() {

        enforcePermission(Manifest.permission.READ_PHONE_STATE);

    }