Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb415770 authored by Pulkit Bhuwalka's avatar Pulkit Bhuwalka Committed by Andre Eisenbach
Browse files

Empty list check to stop Bluetooth stack crash in btif_rc 

Remote devices sometimes poorly send 0 capabilities response when
connecting AVRCP. The stack currently crashes in response to this. We
should not crash and continue. Typically the remote device will send
proper packets in the future and continue to work properly.

Bug: 70140873
Test: Faked 0 capabilities, made stack crash. Added fix, stack stopped
crashing. Verified Bluetooth streaming working.

Change-Id: Id51f0593bc0ddcd3c3085b0d1b1fae136baecceb
parent 47b2dd47

system/btif/src/btif_rc.cc

+9 −0
Original line number Diff line number Diff line
@@ -3119,6 +3119,15 @@ static void handle_get_capability_response(tBTA_AV_META_MSG* pmeta_msg, 
        list_append(p_dev->rc_supported_event_list, p_event);

      }

    }



    // On occasion a remote device can intermittently send a poorly configured

    // packet with 0 capabilities. This check ensures the stack does not crash.

    // Typically the remote device will send a proper packet in the future and

    // continue operation.

    if (list_is_empty(p_dev->rc_supported_event_list)) {

      return;

    }



    p_event =

        (btif_rc_supported_event_t*)list_front(p_dev->rc_supported_event_list);

    if (p_event != NULL) {