Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8228706 authored by Zach Johnson's avatar Zach Johnson
Browse files

Replace unreadable bta_dm_main state machine 

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ie5aaf10f010882f73a084eec235e13050ffe21d6
parent 26b75319

system/bta/dm/bta_dm_main.cc

+102 −188
Original line number Diff line number Diff line
@@ -34,177 +34,6 @@ tBTA_DM_CB bta_dm_cb; 
tBTA_DM_SEARCH_CB bta_dm_search_cb;

tBTA_DM_DI_CB bta_dm_di_cb;



#define BTA_DM_NUM_ACTIONS (BTA_DM_MAX_EVT & 0x00ff)



/* type for action functions */

typedef void (*tBTA_DM_ACTION)(tBTA_DM_MSG* p_data);



/* state machine action enumeration list */

enum {

  BTA_DM_API_SEARCH,                 /* 0 bta_dm_search_start */

  BTA_DM_API_SEARCH_CANCEL,          /* 1 bta_dm_search_cancel */

  BTA_DM_API_DISCOVER,               /* 2 bta_dm_discover */

  BTA_DM_INQUIRY_CMPL,               /* 3 bta_dm_inq_cmpl */

  BTA_DM_REMT_NAME,                  /* 4 bta_dm_rmt_name */

  BTA_DM_SDP_RESULT,                 /* 5 bta_dm_sdp_result */

  BTA_DM_SEARCH_CMPL,                /* 6 bta_dm_search_cmpl*/

  BTA_DM_FREE_SDP_DB,                /* 7 bta_dm_free_sdp_db */

  BTA_DM_DISC_RESULT,                /* 8 bta_dm_disc_result */

  BTA_DM_SEARCH_RESULT,              /* 9 bta_dm_search_result */

  BTA_DM_QUEUE_SEARCH,               /* 10 bta_dm_queue_search */

  BTA_DM_QUEUE_DISC,                 /* 11 bta_dm_queue_disc */

  BTA_DM_SEARCH_CLEAR_QUEUE,         /* 12 bta_dm_search_clear_queue */

  BTA_DM_SEARCH_CANCEL_CMPL,         /* 13 bta_dm_search_cancel_cmpl */

  BTA_DM_SEARCH_CANCEL_NOTIFY,       /* 14 bta_dm_search_cancel_notify */

  BTA_DM_SEARCH_CANCEL_TRANSAC_CMPL, /* 15 bta_dm_search_cancel_transac_cmpl */

  BTA_DM_DISC_RMT_NAME,              /* 16 bta_dm_disc_rmt_name */

  BTA_DM_API_DI_DISCOVER,            /* 17 bta_dm_di_disc */

  BTA_DM_CLOSE_GATT_CONN,            /* 18 bta_dm_close_gatt_conn */

  BTA_DM_SEARCH_NUM_ACTIONS          /* 19 */

};



/* action function list */

const tBTA_DM_ACTION bta_dm_search_action[] = {



    bta_dm_search_start,               /* 0 BTA_DM_API_SEARCH */

    bta_dm_search_cancel,              /* 1 BTA_DM_API_SEARCH_CANCEL */

    bta_dm_discover,                   /* 2 BTA_DM_API_DISCOVER */

    bta_dm_inq_cmpl,                   /* 3 BTA_DM_INQUIRY_CMPL */

    bta_dm_rmt_name,                   /* 4 BTA_DM_REMT_NAME */

    bta_dm_sdp_result,                 /* 5 BTA_DM_SDP_RESULT */

    bta_dm_search_cmpl,                /* 6 BTA_DM_SEARCH_CMPL */

    bta_dm_free_sdp_db,                /* 7 BTA_DM_FREE_SDP_DB */

    bta_dm_disc_result,                /* 8 BTA_DM_DISC_RESULT */

    bta_dm_search_result,              /* 9 BTA_DM_SEARCH_RESULT */

    bta_dm_queue_search,               /* 10 BTA_DM_QUEUE_SEARCH */

    bta_dm_queue_disc,                 /* 11 BTA_DM_QUEUE_DISC */

    bta_dm_search_clear_queue,         /* 12 BTA_DM_SEARCH_CLEAR_QUEUE */

    bta_dm_search_cancel_cmpl,         /* 13 BTA_DM_SEARCH_CANCEL_CMPL */

    bta_dm_search_cancel_notify,       /* 14 BTA_DM_SEARCH_CANCEL_NOTIFY */

    bta_dm_search_cancel_transac_cmpl, /* 15 BTA_DM_SEARCH_CANCEL_TRANSAC_CMPL

                                          */

    bta_dm_disc_rmt_name,              /* 16 BTA_DM_DISC_RMT_NAME */

    bta_dm_di_disc,                    /* 17 BTA_DM_API_DI_DISCOVER */

    bta_dm_close_gatt_conn};



#define BTA_DM_SEARCH_IGNORE BTA_DM_SEARCH_NUM_ACTIONS

/* state table information */

#define BTA_DM_SEARCH_ACTIONS 2    /* number of actions */

#define BTA_DM_SEARCH_NEXT_STATE 2 /* position of next state */

#define BTA_DM_SEARCH_NUM_COLS 3   /* number of columns in state tables */



/* state table for listen state */

const uint8_t bta_dm_search_idle_st_table[][BTA_DM_SEARCH_NUM_COLS] = {



    /* Event                        Action 1

       Action 2                    Next State */

    /* API_SEARCH */ {BTA_DM_API_SEARCH, BTA_DM_SEARCH_IGNORE,

                      BTA_DM_SEARCH_ACTIVE},

    /* API_SEARCH_CANCEL */ {BTA_DM_SEARCH_CANCEL_NOTIFY, BTA_DM_SEARCH_IGNORE,

                             BTA_DM_SEARCH_IDLE},

    /* API_SEARCH_DISC */ {BTA_DM_API_DISCOVER, BTA_DM_SEARCH_IGNORE,

                           BTA_DM_DISCOVER_ACTIVE},

    /* INQUIRY_CMPL */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                        BTA_DM_SEARCH_IDLE},

    /* REMT_NAME_EVT */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                         BTA_DM_SEARCH_IDLE},

    /* SDP_RESULT_EVT */ {BTA_DM_FREE_SDP_DB, BTA_DM_SEARCH_IGNORE,

                          BTA_DM_SEARCH_IDLE},

    /* SEARCH_CMPL_EVT */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                           BTA_DM_SEARCH_IDLE},

    /* DISCV_RES_EVT */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                         BTA_DM_SEARCH_IDLE},

    /* API_DI_DISCOVER_EVT */ {BTA_DM_API_DI_DISCOVER, BTA_DM_SEARCH_IGNORE,

                               BTA_DM_SEARCH_ACTIVE},

    /* DISC_CLOSE_TOUT_EVT */

    {BTA_DM_CLOSE_GATT_CONN, BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IDLE}};

const uint8_t bta_dm_search_search_active_st_table[][BTA_DM_SEARCH_NUM_COLS] = {



    /* Event                        Action 1

       Action 2                    Next State */

    /* API_SEARCH */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                      BTA_DM_SEARCH_ACTIVE},

    /* API_SEARCH_CANCEL */ {BTA_DM_API_SEARCH_CANCEL, BTA_DM_SEARCH_IGNORE,

                             BTA_DM_SEARCH_CANCELLING},

    /* API_SEARCH_DISC */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                           BTA_DM_SEARCH_ACTIVE},

    /* INQUIRY_CMPL */ {BTA_DM_INQUIRY_CMPL, BTA_DM_SEARCH_IGNORE,

                        BTA_DM_SEARCH_ACTIVE},

    /* REMT_NAME_EVT */ {BTA_DM_REMT_NAME, BTA_DM_SEARCH_IGNORE,

                         BTA_DM_SEARCH_ACTIVE},

    /* SDP_RESULT_EVT */ {BTA_DM_SDP_RESULT, BTA_DM_SEARCH_IGNORE,

                          BTA_DM_SEARCH_ACTIVE},

    /* SEARCH_CMPL_EVT */ {BTA_DM_SEARCH_CMPL, BTA_DM_SEARCH_IGNORE,

                           BTA_DM_SEARCH_IDLE},

    /* DISCV_RES_EVT */ {BTA_DM_SEARCH_RESULT, BTA_DM_SEARCH_IGNORE,

                         BTA_DM_SEARCH_ACTIVE},

    /* API_DI_DISCOVER_EVT */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                               BTA_DM_SEARCH_ACTIVE},

    /* DISC_CLOSE_TOUT_EVT */

    {BTA_DM_CLOSE_GATT_CONN, BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_ACTIVE}



};



const uint8_t

    bta_dm_search_search_cancelling_st_table[][BTA_DM_SEARCH_NUM_COLS] = {



        /* Event                        Action 1

           Action 2                    Next State */

        /* API_SEARCH */ {BTA_DM_QUEUE_SEARCH, BTA_DM_SEARCH_IGNORE,

                          BTA_DM_SEARCH_CANCELLING},

        /* API_SEARCH_CANCEL */ {BTA_DM_SEARCH_CLEAR_QUEUE,

                                 BTA_DM_SEARCH_CANCEL_NOTIFY,

                                 BTA_DM_SEARCH_CANCELLING},

        /* API_SEARCH_DISC */ {BTA_DM_QUEUE_DISC, BTA_DM_SEARCH_IGNORE,

                               BTA_DM_SEARCH_CANCELLING},

        /* INQUIRY_CMPL */ {BTA_DM_SEARCH_CANCEL_CMPL, BTA_DM_SEARCH_IGNORE,

                            BTA_DM_SEARCH_IDLE},

        /* REMT_NAME_EVT */ {BTA_DM_SEARCH_CANCEL_TRANSAC_CMPL,

                             BTA_DM_SEARCH_CANCEL_CMPL, BTA_DM_SEARCH_IDLE},

        /* SDP_RESULT_EVT */ {BTA_DM_SEARCH_CANCEL_TRANSAC_CMPL,

                              BTA_DM_SEARCH_CANCEL_CMPL, BTA_DM_SEARCH_IDLE},

        /* SEARCH_CMPL_EVT */ {BTA_DM_SEARCH_CANCEL_TRANSAC_CMPL,

                               BTA_DM_SEARCH_CANCEL_CMPL, BTA_DM_SEARCH_IDLE},

        /* DISCV_RES_EVT */ {BTA_DM_SEARCH_CANCEL_TRANSAC_CMPL,

                             BTA_DM_SEARCH_CANCEL_CMPL, BTA_DM_SEARCH_IDLE},

        /* API_DI_DISCOVER_EVT */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                                   BTA_DM_SEARCH_CANCELLING},

        /* DISC_CLOSE_TOUT_EVT */

        {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_CANCELLING}};



const uint8_t bta_dm_search_disc_active_st_table[][BTA_DM_SEARCH_NUM_COLS] = {



    /* Event                        Action 1

       Action 2                    Next State */

    /* API_SEARCH */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                      BTA_DM_DISCOVER_ACTIVE},

    /* API_SEARCH_CANCEL */ {BTA_DM_SEARCH_CANCEL_NOTIFY, BTA_DM_SEARCH_IGNORE,

                             BTA_DM_SEARCH_CANCELLING},

    /* API_SEARCH_DISC */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                           BTA_DM_DISCOVER_ACTIVE},

    /* INQUIRY_CMPL */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                        BTA_DM_DISCOVER_ACTIVE},

    /* REMT_NAME_EVT */ {BTA_DM_DISC_RMT_NAME, BTA_DM_SEARCH_IGNORE,

                         BTA_DM_DISCOVER_ACTIVE},

    /* SDP_RESULT_EVT */ {BTA_DM_SDP_RESULT, BTA_DM_SEARCH_IGNORE,

                          BTA_DM_DISCOVER_ACTIVE},

    /* SEARCH_CMPL_EVT */ {BTA_DM_SEARCH_CMPL, BTA_DM_SEARCH_IGNORE,

                           BTA_DM_SEARCH_IDLE},

    /* DISCV_RES_EVT */ {BTA_DM_DISC_RESULT, BTA_DM_SEARCH_IGNORE,

                         BTA_DM_DISCOVER_ACTIVE},

    /* API_DI_DISCOVER_EVT */ {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE,

                               BTA_DM_DISCOVER_ACTIVE},

    /* DISC_CLOSE_TOUT_EVT */

    {BTA_DM_SEARCH_IGNORE, BTA_DM_SEARCH_IGNORE, BTA_DM_DISCOVER_ACTIVE}};



typedef const uint8_t (*tBTA_DM_ST_TBL)[BTA_DM_SEARCH_NUM_COLS];



/* state table */

const tBTA_DM_ST_TBL bta_dm_search_st_tbl[] = {

    bta_dm_search_idle_st_table, bta_dm_search_search_active_st_table,

    bta_dm_search_search_cancelling_st_table,

    bta_dm_search_disc_active_st_table};



/*******************************************************************************

 *

 * Function         bta_dm_sm_search_disable
@@ -217,6 +46,8 @@ const tBTA_DM_ST_TBL bta_dm_search_st_tbl[] = { 
 ******************************************************************************/

void bta_dm_search_sm_disable() { bta_sys_deregister(BTA_ID_DM_SEARCH); }



void bta_dm_search_set_state(uint8_t state) { bta_dm_search_cb.state = state; }



/*******************************************************************************

 *

 * Function         bta_dm_search_sm_execute
@@ -228,27 +59,110 @@ void bta_dm_search_sm_disable() { bta_sys_deregister(BTA_ID_DM_SEARCH); } 
 *

 ******************************************************************************/

bool bta_dm_search_sm_execute(BT_HDR* p_msg) {

  tBTA_DM_ST_TBL state_table;

  uint8_t action;

  int i;



  APPL_TRACE_EVENT("bta_dm_search_sm_execute state:%d, event:0x%x",

                   bta_dm_search_cb.state, p_msg->event);



  /* look up the state table for the current state */

  state_table = bta_dm_search_st_tbl[bta_dm_search_cb.state];



  bta_dm_search_cb.state =

      state_table[p_msg->event & 0x00ff][BTA_DM_SEARCH_NEXT_STATE];



  /* execute action functions */

  for (i = 0; i < BTA_DM_SEARCH_ACTIONS; i++) {

    action = state_table[p_msg->event & 0x00ff][i];

    if (action != BTA_DM_SEARCH_IGNORE) {

      (*bta_dm_search_action[action])((tBTA_DM_MSG*)p_msg);

    } else {

  tBTA_DM_MSG* message = (tBTA_DM_MSG*)p_msg;

  switch (bta_dm_search_cb.state) {

    case BTA_DM_SEARCH_IDLE:

      switch (p_msg->event) {

        case BTA_DM_API_SEARCH_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_ACTIVE);

          bta_dm_search_start(message);

          break;

        case BTA_DM_API_SEARCH_CANCEL_EVT:

          bta_dm_search_cancel_notify(message);

          break;

        case BTA_DM_API_DISCOVER_EVT:

          bta_dm_search_set_state(BTA_DM_DISCOVER_ACTIVE);

          bta_dm_discover(message);

          break;

        case BTA_DM_SDP_RESULT_EVT:

          bta_dm_free_sdp_db(message);

          break;

        case BTA_DM_API_DI_DISCOVER_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_ACTIVE);

          bta_dm_di_disc(message);

          break;

        case BTA_DM_DISC_CLOSE_TOUT_EVT:

          bta_dm_close_gatt_conn(message);

          break;

      }

      break;

    case BTA_DM_SEARCH_ACTIVE:

      switch (p_msg->event) {

        case BTA_DM_API_SEARCH_CANCEL_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_CANCELLING);

          bta_dm_search_cancel(message);

          break;

        case BTA_DM_INQUIRY_CMPL_EVT:

          bta_dm_inq_cmpl(message);

          break;

        case BTA_DM_REMT_NAME_EVT:

          bta_dm_rmt_name(message);

          break;

        case BTA_DM_SDP_RESULT_EVT:

          bta_dm_sdp_result(message);

          break;

        case BTA_DM_SEARCH_CMPL_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_IDLE);

          bta_dm_search_cmpl(message);

          break;

        case BTA_DM_DISCOVERY_RESULT_EVT:

          bta_dm_search_result(message);

          break;

        case BTA_DM_DISC_CLOSE_TOUT_EVT:

          bta_dm_close_gatt_conn(message);

          break;

      }

      break;

    case BTA_DM_SEARCH_CANCELLING:

      switch (p_msg->event) {

        case BTA_DM_API_SEARCH_EVT:

          bta_dm_queue_search(message);

          break;

        case BTA_DM_API_SEARCH_CANCEL_EVT:

          bta_dm_search_clear_queue(message);

          bta_dm_search_cancel_notify(message);

          break;

        case BTA_DM_API_DISCOVER_EVT:

          bta_dm_queue_disc(message);

          break;

        case BTA_DM_INQUIRY_CMPL_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_IDLE);

          bta_dm_search_cancel_cmpl(message);

          break;

        case BTA_DM_SDP_RESULT_EVT:

        case BTA_DM_REMT_NAME_EVT:

        case BTA_DM_SEARCH_CMPL_EVT:

        case BTA_DM_DISCOVERY_RESULT_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_IDLE);

          bta_dm_search_cancel_transac_cmpl(message);

          bta_dm_search_cancel_cmpl(message);

          break;

      }

      break;

    case BTA_DM_DISCOVER_ACTIVE:

      switch (p_msg->event) {

        case BTA_DM_API_SEARCH_CANCEL_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_CANCELLING);

          bta_dm_search_cancel_notify(message);

          break;

        case BTA_DM_REMT_NAME_EVT:

          bta_dm_rmt_name(message);

          break;

        case BTA_DM_SDP_RESULT_EVT:

          bta_dm_sdp_result(message);

          break;

        case BTA_DM_SEARCH_CMPL_EVT:

          bta_dm_search_set_state(BTA_DM_SEARCH_IDLE);

          bta_dm_search_cmpl(message);

          break;

        case BTA_DM_DISCOVERY_RESULT_EVT:

          bta_dm_disc_result(message);

          break;

      }

      break;

  }

  return true;

}