Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3bf26a3 authored by Yuyang Huang's avatar Yuyang Huang
Browse files

Fix a potential null pointer dereference in btif_hf_client_upstreams_evt. 

This CL adds a null check for p_data before dereferencing it. This is to prevent a potential crash if p_data is null.

Bug: 324830451
Change-Id: I776a68a13bb34f951efc6740e24f26765be76439
Flag: exempt, nullptr check
Test: m packages/modules/Bluetooth
parent 86f579fb

system/btif/src/btif_hf_client.cc

+4 −0
Original line number Diff line number Diff line
@@ -867,6 +867,10 @@ static void process_ind_evt(tBTA_HF_CLIENT_IND* ind) { 
static void btif_hf_client_upstreams_evt(uint16_t event, char* p_param) {

  tBTA_HF_CLIENT* p_data = (tBTA_HF_CLIENT*)p_param;



  if (p_data == nullptr) {

    log::error("event={} ({})'s param is null", dump_hf_client_event(event), event);

    return;

  }

  btif_hf_client_cb_t* cb = btif_hf_client_get_cb_by_bda(p_data->bd_addr);

  if (cb == NULL && event == BTA_HF_CLIENT_OPEN_EVT) {

    log::verbose("event BTA_HF_CLIENT_OPEN_EVT allocating block");