Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f100f0ab authored by Jakub Pawlowski's avatar Jakub Pawlowski
Browse files

Get rid of bta_dm string checking tests 

This test does not verify much logic and is preventing subsequent CLs from removing the default switch-case

Test: mma -j32
Bug: 330675788
Flag: exempt, test only change
Change-Id: I8ba33334b1a4a644cccee7fc796aaf0ffa8e554f
parent 5b44509e

system/bta/test/bta_dm_test.cc

+0 −41
Original line number Diff line number Diff line
@@ -315,47 +315,6 @@ TEST_F(BtaDmTest, bta_dm_encrypt_cback) { 
  ASSERT_EQ(BTA_FAILURE, params_BTM_ILLEGAL_VALUE.result);

}



TEST_F(BtaDmTest, bta_dm_event_text) {

  std::vector<std::pair<tBTA_DM_EVT, std::string>> events = {

      std::make_pair(BTA_DM_API_SEARCH_EVT, "BTA_DM_API_SEARCH_EVT"),

      std::make_pair(BTA_DM_API_DISCOVER_EVT, "BTA_DM_API_DISCOVER_EVT"),

      std::make_pair(BTA_DM_INQUIRY_CMPL_EVT, "BTA_DM_INQUIRY_CMPL_EVT"),

      std::make_pair(BTA_DM_REMT_NAME_EVT, "BTA_DM_REMT_NAME_EVT"),

      std::make_pair(BTA_DM_SDP_RESULT_EVT, "BTA_DM_SDP_RESULT_EVT"),

      std::make_pair(BTA_DM_SEARCH_CMPL_EVT, "BTA_DM_SEARCH_CMPL_EVT"),

      std::make_pair(BTA_DM_DISCOVERY_RESULT_EVT,

                     "BTA_DM_DISCOVERY_RESULT_EVT"),

      std::make_pair(BTA_DM_DISC_CLOSE_TOUT_EVT, "BTA_DM_DISC_CLOSE_TOUT_EVT"),

  };

  for (const auto& event : events) {

    ASSERT_STREQ(event.second.c_str(), bta_dm_event_text(event.first).c_str());

  }

  ASSERT_STREQ(base::StringPrintf("UNKNOWN[0x%04x]",

                                  std::numeric_limits<uint16_t>::max())

                   .c_str(),

               bta_dm_event_text(static_cast<tBTA_DM_EVT>(

                                     std::numeric_limits<uint16_t>::max()))

                   .c_str());

}



TEST_F(BtaDmTest, bta_dm_state_text) {

  std::vector<std::pair<tBTA_DM_STATE, std::string>> states = {

      std::make_pair(BTA_DM_SEARCH_IDLE, "BTA_DM_SEARCH_IDLE"),

      std::make_pair(BTA_DM_SEARCH_ACTIVE, "BTA_DM_SEARCH_ACTIVE"),

      std::make_pair(BTA_DM_SEARCH_CANCELLING, "BTA_DM_SEARCH_CANCELLING"),

      std::make_pair(BTA_DM_DISCOVER_ACTIVE, "BTA_DM_DISCOVER_ACTIVE"),

  };

  for (const auto& state : states) {

    ASSERT_STREQ(state.second.c_str(), bta_dm_state_text(state.first).c_str());

  }

  auto unknown =

      base::StringPrintf("UNKNOWN[%d]", std::numeric_limits<int>::max());

  ASSERT_STREQ(unknown.c_str(),

               bta_dm_state_text(

                   static_cast<tBTA_DM_STATE>(std::numeric_limits<int>::max()))

                   .c_str());

}



TEST_F(BtaDmTest, bta_dm_remname_cback__typical) {

  tBTA_DM_SEARCH_CB& search_cb =

      bluetooth::legacy::testing::bta_dm_disc_search_cb();