Commit ec4abb2e authored Aug 20, 2021 by Erwin Jansen

Remove non-determinism in socket unit test.

It is possible that there is some delay when a server socket is closed.
Due to this it is possible on slower machines to fail the
noConnectWhenNotCallingStart test (esp. on mac build bots that are under
heavy load).

We now remove this part of the test as the eventual part is hard to
measure.

Test: ran unit tests
Bug: 197374965
Change-Id: Icb5092fe9aceee174f507152d9a6c861f86c24cf

parent 622c78dd

system/vendor_libs/test_vendor_lib/test/posix_socket_unittest.cc

+0 −4

Original line number	Diff line number	Diff line
		@@ -302,10 +302,6 @@ TEST_F(PosixSocketTest, noConnectWhenNotCallingStart) {

		// Should timeout, as we never invoke the callback that accepts the socket.
		ASSERT_FALSE(cv.wait_for(lk, 250ms, [&] { return connected; }));

		// Close the server socket, which will reject the socket.
		pass_.Close();
		ASSERT_FALSE(socket->Connected());
		}

		ASSERT_EQ(1, (int)connections.size());