Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb8eefcf authored by Jack He's avatar Jack He Committed by android-build-merger
Browse files

Merge "MAP-MNS: Cleanup sdp record on service shutdown"

am: 035c1e4a

Change-Id: I21dc628d2cf67be4135fe181b0477e691d8b49ba
parents 8ba2f20d 035c1e4a
Loading
Loading
Loading
Loading
+26 −3
Original line number Diff line number Diff line
@@ -50,26 +50,49 @@ class MnsService {

    private static MapClientService mContext;
    private volatile boolean mShutdown = false;         // Used to interrupt socket accept thread
    private int mSdpHandle = -1;

    MnsService(MapClientService context) {
        if (VDBG) Log.v(TAG, "MnsService()");
        mContext = context;
        mAcceptThread = new SocketAcceptor();
        mServerSockets = ObexServerSockets.create(mAcceptThread);
        SdpManager.getDefaultManager().createMapMnsRecord(
                "MAP Message Notification Service", mServerSockets.getRfcommChannel(), -1,
                MNS_VERSION, MNS_FEATURE_BITS);
        SdpManager sdpManager = SdpManager.getDefaultManager();
        if (sdpManager == null) {
            Log.e(TAG, "SdpManager is null");
            return;
        }
        mSdpHandle = sdpManager.createMapMnsRecord("MAP Message Notification Service",
                mServerSockets.getRfcommChannel(), -1, MNS_VERSION, MNS_FEATURE_BITS);
    }

    void stop() {
        if (VDBG) Log.v(TAG, "stop()");
        mShutdown = true;
        cleanUpSdpRecord();
        if (mServerSockets != null) {
            mServerSockets.shutdown(false);
            mServerSockets = null;
        }
    }

    private void cleanUpSdpRecord() {
        if (mSdpHandle < 0) {
            Log.e(TAG, "cleanUpSdpRecord, SDP record never created");
            return;
        }
        int sdpHandle = mSdpHandle;
        mSdpHandle = -1;
        SdpManager sdpManager = SdpManager.getDefaultManager();
        if (sdpManager == null) {
            Log.e(TAG, "cleanUpSdpRecord failed, sdpManager is null, sdpHandle=" + sdpHandle);
            return;
        }
        Log.i(TAG, "cleanUpSdpRecord, mSdpHandle=" + sdpHandle);
        if (!sdpManager.removeSdpRecord(sdpHandle)) {
            Log.e(TAG, "cleanUpSdpRecord, removeSdpRecord failed, sdpHandle=" + sdpHandle);
        }
    }

    private class SocketAcceptor implements IObexConnectionHandler {