Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e92e1147 authored by David Srbecky's avatar David Srbecky Committed by Gerrit Code Review
Browse files

Merge changes from topic "revert-2508278-NYSMMYRTQW" 

* changes:
  Revert "Revert "Add template to prevent sharding of some bt test..."
  Revert "Run GTests with ASAN on 32bit only"
parents 99b36e35 2e4b627d

Android.bp

+2 −21
Original line number Diff line number Diff line
@@ -69,25 +69,6 @@ filegroup { 
}



filegroup {

    name: "BluetoothGTestForce32ConfigTemplate",

    srcs: [

        "AndroidGTestForce32Template.xml",

    ],

}



// Address Sanitizer is flaky on Android x86_64 binaries but it's not on x86

// binaries.

// This default workaround the x86_64 ASAN flakyness by running 32bit binaries

// on 64bit targets.

// TODO(b/154347133): Remove this workaround

cc_defaults {

    name: "bluetooth_gtest_x86_asan_workaround",

    target: {

        android_x86: {

            test_config_template: ":BluetoothGTestForce32ConfigTemplate",

        },

        android_x86_64: {

            enabled: false,

        },

    },

    name: "BluetoothGTestNotShardableConfigTemplate",

    srcs: ["AndroidGtestNotShardableTemplate.xml"],

}

AndroidGTestForce32Template.xml→AndroidGtestNotShardableTemplate.xml

+4 −1
Original line number Diff line number Diff line
@@ -14,12 +14,15 @@ 
     limitations under the License.

-->

<configuration description="Runs {MODULE}.">

  <option name="not-shardable" value="true" />



  <option name="test-suite-tag" value="apct" />

  <option name="test-suite-tag" value="apct-native" />

  <target_preparer class="com.android.tradefed.targetprep.RootTargetPreparer" />

  <target_preparer class="com.android.compatibility.common.tradefed.targetprep.FilePusher">

        <option name="cleanup" value="true" />

        <option name="push" value="{MODULE}32->/data/local/tmp/{MODULE}" />

        <option name="push" value="{MODULE}->/data/local/tmp/{MODULE}" />

        <option name="append-bitness" value="true" />

    </target_preparer>

  <target_preparer class="com.android.tradefed.targetprep.RunCommandTargetPreparer">

    <option name="run-command" value="settings put global ble_scan_always_enabled 0" />

system/audio_a2dp_hw/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -61,7 +61,6 @@ cc_test { 
    defaults: [

        "audio_a2dp_hw_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    srcs: [

        "test/audio_a2dp_hw_test.cc",

system/audio_hearing_aid_hw/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -43,7 +43,6 @@ cc_test { 
    defaults: [

        "audio_hearing_aid_hw_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    srcs: [

        "test/audio_hearing_aid_hw_test.cc",

system/bta/Android.bp

+5 −11
Original line number Diff line number Diff line
@@ -187,7 +187,6 @@ cc_test { 
    defaults: [

        "fluoride_bta_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    test_suites: ["device-tests"],

    srcs: [
@@ -234,7 +233,6 @@ cc_test { 
    defaults: [

        "fluoride_bta_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    test_suites: ["device-tests"],

    host_supported: true,
@@ -327,7 +325,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -382,7 +379,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -425,7 +421,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -545,7 +540,6 @@ cc_test { 
        "fluoride_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    target: {
@@ -634,7 +628,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -728,7 +721,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -780,7 +772,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -852,7 +843,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -909,7 +899,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -971,4 +960,9 @@ cc_test { 
            undefined: true,

        },

    },

    target: {

        android: {

            test_config_template: ":BluetoothGTestNotShardableConfigTemplate",

        },

    },

}