Commit e7a119a6 authored Jan 31, 2020 by Chris Manton

gd: Fix reactor race condition

If one thread is in Unregister() while another is
in Run(), there is a very small window where
the reactor lock drops allowing Unregister()
to think the reactable is not running, but it is.  So
then the reactable is deleted underneath the Run()
thread and crashy ensues.

Bug: 148703760
Test: bluetooth_test_gd --gtest_filter=L2capClassicLinkTest.* --gtest_repeat=1000000
Change-Id: I11535fdcda2102102e6e9e23baecd5465549c723

parent 5e4de052

system/gd/os/linux_generic/reactor.cc

+4 −4

Original line number	Diff line number	Diff line
		@@ -124,7 +124,6 @@ void Reactor::Run() {
		{
		std::lock_guard<std::mutex> reactable_lock(reactable->mutex_);
		reactable->is_executing_ = false;
		}
		if (reactable->removed_) {
		reactable->finished_promise_->set_value();
		delete reactable;
		@@ -132,6 +131,7 @@ void Reactor::Run() {
		}
		}
		}
		}

		void Reactor::Stop() {
		if (!is_running_) {