Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e48b0f74 authored by Łukasz Rymanowski's avatar Łukasz Rymanowski
Browse files

leaudio: Remove reduntant GroupStatus callback 

Bug: 331775328
Flag: Exempt, trivial fix, unit test added to verify, regression checked
with unit tests.
Test: atest bluetooth_le_audio_client_test

Change-Id: Ie4e62edcb45baeb7da6b9e5c48db53a9eebab716
parent bbf35af7

system/bta/le_audio/client.cc

+0 −1
Original line number Diff line number Diff line
@@ -1297,7 +1297,6 @@ class LeAudioClientImpl : public LeAudioClient { 
     * parameters if needed.

     */

    UpdateConfigAndCheckIfReconfigurationIsNeeded(group, default_context_type);

    callbacks_->OnGroupStatus(group_id, GroupStatus::INACTIVE);



    auto previous_active_group = active_group_id_;

    log::info("Active group_id changed {} -> {}", previous_active_group,

system/bta/le_audio/le_audio_client_test.cc

+6 −0
Original line number Diff line number Diff line
@@ -4811,6 +4811,12 @@ TEST_F(UnicastTest, GroupSetActive) { 
  EXPECT_CALL(mock_audio_hal_client_callbacks_,

              OnAudioGroupSelectableCodecConf(group_id, _, _))

      .Times(1);

  EXPECT_CALL(mock_audio_hal_client_callbacks_,

              OnGroupStatus(group_id, GroupStatus::ACTIVE))

      .Times(1);

  EXPECT_CALL(mock_audio_hal_client_callbacks_,

              OnGroupStatus(_, GroupStatus::INACTIVE))

      .Times(0);

  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);