Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e428126c authored by Josh Wu's avatar Josh Wu
Browse files

Revert "HFP: Avoid double free SDP" 

This reverts commit da444d82.

Reason for revert: Wrongly merged

Tag: #stability
Test: gd/cert/run
Bug: 202025798
Change-Id: Id3fb00d70d5388cc68a2c8b3143e360c3f46b292
parent da444d82

system/bta/hf_client/bta_hf_client_main.cc

+1 −1
Original line number Diff line number Diff line
@@ -386,7 +386,7 @@ void bta_hf_client_collision_cback(UNUSED_ATTR tBTA_SYS_CONN_STATUS status, 
    /* Cancel SDP if it had been started. */

    if (client_cb->p_disc_db) {

      (void)SDP_CancelServiceSearch(client_cb->p_disc_db);

      bta_hf_client_free_db(NULL);

      osi_free_and_reset((void**)&client_cb->p_disc_db);

    }



    /* reopen registered server */

system/bta/hf_client/bta_hf_client_rfc.cc

+1 −1
Original line number Diff line number Diff line
@@ -288,7 +288,7 @@ void bta_hf_client_rfc_do_close(tBTA_HF_CLIENT_DATA* p_data) { 
    /* Cancel SDP if it had been started. */

    if (client_cb->p_disc_db) {

      (void)SDP_CancelServiceSearch(client_cb->p_disc_db);

      bta_hf_client_free_db(NULL);

      osi_free_and_reset((void**)&client_cb->p_disc_db);

    }

  }

}

system/bta/hf_client/bta_hf_client_sdp.cc

+2 −1
Original line number Diff line number Diff line
@@ -336,7 +336,7 @@ void bta_hf_client_do_disc(tBTA_HF_CLIENT_CB* client_cb) { 


  if (!db_inited) {

    /*free discover db */

    bta_hf_client_free_db(NULL);

    osi_free_and_reset((void**)&client_cb->p_disc_db);

    /* sent failed event */

    tBTA_HF_CLIENT_DATA msg;

    msg.hdr.layer_specific = client_cb->handle;
@@ -355,6 +355,7 @@ void bta_hf_client_do_disc(tBTA_HF_CLIENT_CB* client_cb) { 
 *

 ******************************************************************************/

void bta_hf_client_free_db(tBTA_HF_CLIENT_DATA* p_data) {

  CHECK(p_data != NULL);

  tBTA_HF_CLIENT_CB* client_cb =

      bta_hf_client_find_cb_by_handle(p_data->hdr.layer_specific);

  if (client_cb == NULL) {