Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e32fedc8 authored by Jack He's avatar Jack He
Browse files

HCI: Change CreateAdvertiser overload to ExtendedCreateAdvertiser 

* They are inherently different methods and I want to make it more
  obvious that we are calling different methods when creating
  advertiser

Bug: 140938432
Test: make and facade tests
Change-Id: Ib8047a21f0ce8aef71629e861876fa6b408c32f9
parent caecce53

system/gd/hci/le_advertising_manager.cc

+1 −1
Original line number Diff line number Diff line
@@ -286,7 +286,7 @@ AdvertiserId LeAdvertisingManager::CreateAdvertiser( 
  return id;

}



AdvertiserId LeAdvertisingManager::CreateAdvertiser(

AdvertiserId LeAdvertisingManager::ExtendedCreateAdvertiser(

    const ExtendedAdvertisingConfig& config, const common::Callback<void(Address, AddressType)>& scan_callback,

    const common::Callback<void(ErrorCode, uint8_t, uint8_t)>& set_terminated_callback, os::Handler* handler) {

  if (config.directed) {

system/gd/hci/le_advertising_manager.h

+3 −4
Original line number Diff line number Diff line
@@ -69,10 +69,9 @@ class LeAdvertisingManager : public bluetooth::Module { 
                                const common::Callback<void(Address, AddressType)>& scan_callback,

                                const common::Callback<void(ErrorCode, uint8_t, uint8_t)>& set_terminated_callback,

                                os::Handler* handler);

  AdvertiserId CreateAdvertiser(const ExtendedAdvertisingConfig& config,

                                const common::Callback<void(Address, AddressType)>& scan_callback,

                                const common::Callback<void(ErrorCode, uint8_t, uint8_t)>& set_terminated_callback,

                                os::Handler* handler);

  AdvertiserId ExtendedCreateAdvertiser(

      const ExtendedAdvertisingConfig& config, const common::Callback<void(Address, AddressType)>& scan_callback,

      const common::Callback<void(ErrorCode, uint8_t, uint8_t)>& set_terminated_callback, os::Handler* handler);



  void RemoveAdvertiser(AdvertiserId id);