Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de409ecb authored by Martin Geisler's avatar Martin Geisler Committed by Cherrypicker Worker
Browse files

pdl: Explain possible canonical test failures 

Test: atest pdl_tests pdl_rust_generator_tests_{le,be}
(cherry picked from https://android-review.googlesource.com/q/commit:a1ee89e3864cd7ca6e264fb450d5e002f54ff8e5)
Merged-In: I6366b88f2b4683baf21e31519ccd981b6e81a380
Change-Id: I6366b88f2b4683baf21e31519ccd981b6e81a380
parent 68d8bf33

tools/pdl/src/bin/generate-canonical-tests.rs

+4 −2
Original line number Original line Diff line number Diff line
@@ -84,7 +84,8 @@ fn generate_unit_tests(input: &str, packet_names: &[&str], module_name: &str) { 
                let expected = format_ident!("expected_{key}");

                let expected = format_ident!("expected_{key}");

                let json = to_json(&value);

                let json = to_json(&value);

                quote! {

                quote! {

                    let #expected: serde_json::Value = serde_json::from_str(#json).unwrap();

                    let #expected: serde_json::Value = serde_json::from_str(#json)

                        .expect("Could not create expected value from canonical JSON data");

                    assert_eq!(json!(actual.#getter()), #expected);

                    assert_eq!(json!(actual.#getter()), #expected);

                }

                }

            });

            });
@@ -100,7 +101,8 @@ fn generate_unit_tests(input: &str, packet_names: &[&str], module_name: &str) { 




                #[test]

                #[test]

                fn #serialize_test_name() {

                fn #serialize_test_name() {

                    let builder: #module::#builder_name = serde_json::from_str(#json).unwrap();

                    let builder: #module::#builder_name = serde_json::from_str(#json)

                        .expect("Could not create builder from canonical JSON data");

                    let packet = builder.build();

                    let packet = builder.build();

                    let packed = #packed;

                    let packed = #packed;

                    assert_eq!(packet.to_vec(), packed);

                    assert_eq!(packet.to_vec(), packed);