Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddf6320b authored by Nitin Arora's avatar Nitin Arora Committed by Jakub Pawlowski
Browse files

Prevent multiple register of service change indication 

Use Case:
Pair DUT to a remote LE device. The host registers for the service
change indication twice, once when the connection callback is
received and another time, when the SMP process completes

Failure:
There are a few issues caused by this.
First, the duplicate action of service change indication registeration
is unnecessary.
The registeration that follows the SMP process adds a gatt_if to the
apps holding the current link. This gatt_if (=1) never disconnects
after registeration failure or success. And hence the host can never
physically disconnect the link.

Fix:
This change removes the service change registeration at SMP
process completion

Test: manual
Change-Id: I0d7566e2b4a9d01aa7926cdbe9f528c3941fcfeb
parent 3f03ae48

system/bta/dm/bta_dm_act.cc

+0 −2
Original line number Diff line number Diff line
@@ -4413,8 +4413,6 @@ static uint8_t bta_dm_ble_smp_cback (tBTM_LE_EVT event, BD_ADDR bda, tBTM_LE_EVT 
            else

            {

                sec_event.auth_cmpl.success = true;

                if (!p_data->complt.smp_over_br)

                    GATT_ConfigServiceChangeCCC(bda, true, BT_TRANSPORT_LE);

            }



            if (bta_dm_cb.p_sec_cback)