Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc96aaed authored by Henri Chataing's avatar Henri Chataing
Browse files

gd/packet: Deprecate PDL pybind11 wrapper generation 

All uses have been either removed or migrated to the pure
python generator attached to pdl rust.

Test: m com.android.btservices
Bug: 295891051
Flag: EXEMPT, tool change
Change-Id: I7c4faacde463b2ad99c0b88cf6ab1d3d0820e464
parent 0f066135

system/gd/hci/address_pybind11_type_caster.h

deleted100644 → 0
+0 −55
Original line number Diff line number Diff line 
/******************************************************************************

 *

 *  Copyright 2019 The Android Open Source Project

 *

 *  Licensed under the Apache License, Version 2.0 (the "License");

 *  you may not use this file except in compliance with the License.

 *  You may obtain a copy of the License at:

 *

 *  http://www.apache.org/licenses/LICENSE-2.0

 *

 *  Unless required by applicable law or agreed to in writing, software

 *  distributed under the License is distributed on an "AS IS" BASIS,

 *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 *  See the License for the specific language governing permissions and

 *  limitations under the License.

 *

 ******************************************************************************/



#pragma once



#include <cstring>

#include <string>



#include <pybind11/pybind11.h>

#include <pybind11/stl.h>



#include "hci/address.h"



namespace py = pybind11;



namespace pybind11 {

namespace detail {

template <>

struct type_caster<::bluetooth::hci::Address> {

 public:

  // Set the Python name of Address and declare "value"

  PYBIND11_TYPE_CASTER(::bluetooth::hci::Address, _("Address"));



  // Convert from Python->C++

  bool load(handle src, bool) {

    PyObject* source = src.ptr();

    if (py::isinstance<py::str>(src)) {

      bool conversion_successful = bluetooth::hci::Address::FromString(PyUnicode_AsUTF8(source), value);

      return conversion_successful && !PyErr_Occurred();

    }

    return false;

  }



  // Convert from C++->Python

  static handle cast(bluetooth::hci::Address src, return_value_policy, handle) {

    return PyUnicode_FromString(src.ToString().c_str());

  }

};

}  // namespace detail

}  // namespace pybind11

system/gd/hci/class_of_device_pybind11_type_caster.h

deleted100644 → 0
+0 −55
Original line number Diff line number Diff line 
/******************************************************************************

 *

 *  Copyright 2019 The Android Open Source Project

 *

 *  Licensed under the Apache License, Version 2.0 (the "License");

 *  you may not use this file except in compliance with the License.

 *  You may obtain a copy of the License at:

 *

 *  http://www.apache.org/licenses/LICENSE-2.0

 *

 *  Unless required by applicable law or agreed to in writing, software

 *  distributed under the License is distributed on an "AS IS" BASIS,

 *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 *  See the License for the specific language governing permissions and

 *  limitations under the License.

 *

 ******************************************************************************/



#pragma once



#include <cstring>

#include <string>



#include <pybind11/pybind11.h>

#include <pybind11/stl.h>



#include "hci/class_of_device.h"



namespace py = pybind11;



namespace pybind11 {

namespace detail {

template <>

struct type_caster<::bluetooth::hci::ClassOfDevice> {

 public:

  // Set the Python name of ClassOfDevice and declare "value"

  PYBIND11_TYPE_CASTER(::bluetooth::hci::ClassOfDevice, _("ClassOfDevice"));



  // Convert from Python->C++

  bool load(handle src, bool) {

    PyObject* source = src.ptr();

    if (py::isinstance<py::str>(src)) {

      bool conversion_successful = bluetooth::hci::ClassOfDevice::FromString(PyUnicode_AsUTF8(source), value);

      return conversion_successful && !PyErr_Occurred();

    }

    return false;

  }



  // Convert from C++->Python

  static handle cast(bluetooth::hci::ClassOfDevice src, return_value_policy, handle) {

    return PyUnicode_FromString(src.ToString().c_str());

  }

};

}  // namespace detail

}  // namespace pybind11

system/gd/packet/parser/custom_field_def.cc

+0 −4
Original line number Diff line number Diff line
@@ -43,10 +43,6 @@ void CustomFieldDef::GenInclude(std::ostream& s) const { 
  s << "#include \"" << include_ << util::CamelCaseToUnderScore(GetTypeName()) << ".h\"\n";

}



void CustomFieldDef::GenPyBind11Include(std::ostream& s) const {

  s << "#include \"" << include_ << util::CamelCaseToUnderScore(GetTypeName()) << "_pybind11_type_caster.h\"\n";

}



void CustomFieldDef::GenUsing(std::ostream& s) const {

  s << "using ::bluetooth::";

  for (const auto& c : include_) {

system/gd/packet/parser/custom_field_def.h

+0 −2
Original line number Diff line number Diff line
@@ -35,8 +35,6 @@ class CustomFieldDef : public TypeDef { 


  void GenInclude(std::ostream& s) const;



  void GenPyBind11Include(std::ostream& s) const;



  void GenUsing(std::ostream& s) const;



  void GenFixedSizeCustomFieldCheck(std::ostream& s) const;

system/gd/packet/parser/gen_cpp.cc

+0 −156
Original line number Diff line number Diff line
@@ -283,159 +283,3 @@ std::ofstream& get_out_file(size_t symbol_count, size_t symbol_total, std::vecto 
  auto file_index = std::min(symbol_count / symbols_per_shard, out_files->size() - 1);

  return out_files->at(file_index);

}
 


bool generate_pybind11_sources_one_file(

    const Declarations& decls,

    const std::filesystem::path& input_file,

    const std::filesystem::path& include_dir,

    const std::filesystem::path& out_dir,

    const std::string& root_namespace,

    size_t num_shards) {

  auto gen_relative_path = input_file.lexically_relative(include_dir).parent_path();



  auto input_filename = input_file.filename().string().substr(0, input_file.filename().string().find(".pdl"));

  auto gen_path = out_dir / gen_relative_path;



  std::filesystem::create_directories(gen_path);



  auto gen_relative_header = gen_relative_path / (input_filename + ".h");



  std::vector<std::string> namespace_list;

  parse_namespace(root_namespace, gen_relative_path, &namespace_list);



  std::vector<std::ofstream> out_file_shards(num_shards);

  for (size_t i = 0; i < out_file_shards.size(); i++) {

    auto filename = gen_path / (input_filename + "_python3_shard_" + std::to_string(i) + ".cc");

    std::cout << "generating " << filename << std::endl;

    auto& out_file = out_file_shards[i];

    out_file.open(filename);

    if (!out_file.is_open()) {

      std::cerr << "can't open " << filename << std::endl;

      return false;

    }

    out_file << "#include <pybind11/pybind11.h>\n";

    out_file << "#include <pybind11/stl.h>\n";

    out_file << "\n\n";

    out_file << "#include " << gen_relative_header << "\n";

    out_file << "\n\n";

    out_file << "#include \"packet/raw_builder.h\"\n";

    out_file << "\n\n";



    for (const auto& c : decls.type_defs_queue_) {

      if (c.second->GetDefinitionType() == TypeDef::Type::CUSTOM) {

        const auto* custom_def = static_cast<const CustomFieldDef*>(c.second);

        custom_def->GenPyBind11Include(out_file);

      }

    }



    out_file << "\n\n";



    generate_namespace_open(namespace_list, out_file);

    out_file << "\n\n";



    for (const auto& c : decls.type_defs_queue_) {

      if (c.second->GetDefinitionType() == TypeDef::Type::CUSTOM ||

          c.second->GetDefinitionType() == TypeDef::Type::CHECKSUM) {

        const auto* custom_def = static_cast<const CustomFieldDef*>(c.second);

        custom_def->GenUsing(out_file);

      }

    }

    out_file << "\n\n";



    out_file << "using ::bluetooth::packet::BasePacketBuilder;";

    out_file << "using ::bluetooth::packet::BitInserter;";

    out_file << "using ::bluetooth::packet::CustomTypeChecker;";

    out_file << "using ::bluetooth::packet::Iterator;";

    out_file << "using ::bluetooth::packet::kLittleEndian;";

    out_file << "using ::bluetooth::packet::PacketBuilder;";

    out_file << "using ::bluetooth::packet::BaseStruct;";

    out_file << "using ::bluetooth::packet::PacketStruct;";

    out_file << "using ::bluetooth::packet::PacketView;";

    out_file << "using ::bluetooth::packet::RawBuilder;";

    out_file << "using ::bluetooth::packet::parser::ChecksumTypeChecker;";

    out_file << "\n\n";



    out_file << "namespace py = pybind11;\n\n";



    out_file << "void define_" << input_filename << "_submodule_shard_" << std::to_string(i) << "(py::module& m) {\n\n";

  }

  size_t symbol_total = 0;

  // Only count types that will be generated

  for (const auto& e : decls.type_defs_queue_) {

    if (e.second->GetDefinitionType() == TypeDef::Type::ENUM) {

      symbol_total++;

    } else if (e.second->GetDefinitionType() == TypeDef::Type::STRUCT) {

      symbol_total++;

    }

  }

  // View and builder are counted separately

  symbol_total += decls.packet_defs_queue_.size() * 2;

  size_t symbol_count = 0;



  for (const auto& e : decls.type_defs_queue_) {

    if (e.second->GetDefinitionType() == TypeDef::Type::ENUM) {

      const auto* enum_def = static_cast<const EnumDef*>(e.second);

      EnumGen gen(*enum_def);

      auto& out_file = get_out_file(symbol_count, symbol_total, &out_file_shards);

      gen.GenDefinitionPybind11(out_file);

      out_file << "\n\n";

      symbol_count++;

    }

  }



  for (const auto& s : decls.type_defs_queue_) {

    if (s.second->GetDefinitionType() == TypeDef::Type::STRUCT) {

      const auto* struct_def = static_cast<const StructDef*>(s.second);

      auto& out_file = get_out_file(symbol_count, symbol_total, &out_file_shards);

      struct_def->GenDefinitionPybind11(out_file);

      out_file << "\n";

      symbol_count++;

    }

  }



  for (const auto& packet_def : decls.packet_defs_queue_) {

    auto& out_file = get_out_file(symbol_count, symbol_total, &out_file_shards);

    packet_def.second->GenParserDefinitionPybind11(out_file);

    out_file << "\n\n";

    symbol_count++;

  }



  for (const auto& p : decls.packet_defs_queue_) {

    auto& out_file = get_out_file(symbol_count, symbol_total, &out_file_shards);

    p.second->GenBuilderDefinitionPybind11(out_file);

    out_file << "\n\n";

    symbol_count++;

  }



  for (auto& out_file : out_file_shards) {

    out_file << "}\n\n";

    generate_namespace_close(namespace_list, out_file);

  }



  auto gen_file_main = gen_path / (input_filename + "_python3.cc");

  std::ofstream out_file_main;

  out_file_main.open(gen_file_main);

  if (!out_file_main.is_open()) {

    std::cerr << "can't open " << gen_file_main << std::endl;

    return false;

  }

  out_file_main << "#include <pybind11/pybind11.h>\n";

  generate_namespace_open(namespace_list, out_file_main);



  out_file_main << "namespace py = pybind11;\n\n";



  for (size_t i = 0; i < out_file_shards.size(); i++) {

    out_file_main << "void define_" << input_filename << "_submodule_shard_" << std::to_string(i)

                  << "(py::module& m);\n";

  }



  out_file_main << "void define_" << input_filename << "_submodule(py::module& m) {\n\n";

  for (size_t i = 0; i < out_file_shards.size(); i++) {

    out_file_main << "define_" << input_filename << "_submodule_shard_" << std::to_string(i) << "(m);\n";

  }

  out_file_main << "}\n\n";



  generate_namespace_close(namespace_list, out_file_main);



  return true;

}