Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9c5af50 authored by Myles Watson's avatar Myles Watson
Browse files

InitFlags: Remove robust_caching_enabled 

Bug: 236983667
Fixes: 290844046
Test: mma -j32
Flag: EXEMPT, no logical change
Change-Id: I09784c47ff56417b50b825a42671a1a680281e77
parent 3bb63109

system/gd/rust/common/src/init_flags.rs

+0 −17
Original line number Diff line number Diff line
@@ -209,7 +209,6 @@ init_flags!( 
    flags: {

        classic_discovery_only,

        dynamic_avrcp_version_enhancement = true,

        gatt_robust_caching_server,

        hci_adapter: i32,

        hfp_dynamic_version = true,

        irk_rotation,
@@ -268,22 +267,6 @@ mod tests { 
        load(raw_flags);

    }



    #[test]

    fn simple_flag() {

        let _guard = ASYNC_LOCK.lock().unwrap();

        test_load(vec!["INIT_gatt_robust_caching_server=true"]);

        assert!(gatt_robust_caching_server_is_enabled());

    }

    #[test]

    fn parsing_failure() {

        let _guard = ASYNC_LOCK.lock().unwrap();

        test_load(vec![

            "foo=bar=?",                                // vec length

            "foo=bar",                                  // flag not save

            "INIT_gatt_robust_caching_server=not_true", // parse error

        ]);

        assert!(!gatt_robust_caching_server_is_enabled());

    }

    #[test]

    fn int_flag() {

        let _guard = ASYNC_LOCK.lock().unwrap();

system/gd/rust/shim/src/init_flags.rs

+0 −1
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ mod ffi { 


        fn classic_discovery_only_is_enabled() -> bool;

        fn dynamic_avrcp_version_enhancement_is_enabled() -> bool;

        fn gatt_robust_caching_server_is_enabled() -> bool;

        fn get_hci_adapter() -> i32;

        fn hfp_dynamic_version_is_enabled() -> bool;

        fn irk_rotation_is_enabled() -> bool;

system/stack/gatt/gatt_attr.cc

+1 −3
Original line number Diff line number Diff line
@@ -1011,9 +1011,7 @@ bool gatt_profile_get_eatt_support(const RawAddress& remote_bda) { 
 * Returns          true if enabled in gd flag, otherwise false

 *

 ******************************************************************************/

static bool gatt_sr_is_robust_caching_enabled() {

  return bluetooth::common::init_flags::gatt_robust_caching_server_is_enabled();

}

static bool gatt_sr_is_robust_caching_enabled() { return false; }



/*******************************************************************************

 *