Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9890e5c authored by Marie Janssen's avatar Marie Janssen
Browse files

btif: GetItemAttributes can return no attributes 

If there are no attributes available, it's possible to return zero
attributes from a GetItemAttributes request.

This is triggered by some carkits who are unhappy when they only get
titles back (the only required item) and ask for the rest of the
attributes (which we don't have).

Test: connect to honda carkit and get snoop logs to confirm
Bug: 36055995
Bug: 35956792
Change-Id: I5a31e206565d212e456111d8c6b542c7a1569e5a
parent 8d6df8a3

system/btif/src/btif_rc.cc

+4 −9
Original line number Diff line number Diff line
@@ -2449,16 +2449,11 @@ static bt_status_t get_item_attr_rsp(bt_bdaddr_t* bd_addr, 


  memset(item_attrs, 0, sizeof(tAVRC_ATTR_ENTRY) * num_attr);



  if (num_attr == 0) {

    avrc_rsp.get_attrs.status = AVRC_STS_INTERNAL_ERR;

    BTIF_TRACE_ERROR("%s: num_attr in rsp is 0, sending internal error: 0x%02X",

                     __func__, avrc_rsp.get_attrs.status);

  } else {

  avrc_rsp.get_attrs.status = status_code_map[rsp_status];

  if (rsp_status == BTRC_STS_NO_ERROR) {

    fill_avrc_attr_entry(item_attrs, num_attr, p_attrs);

  }

  }



  avrc_rsp.get_attrs.num_attrs = num_attr;

  avrc_rsp.get_attrs.p_attrs = item_attrs;

  avrc_rsp.get_attrs.pdu = AVRC_PDU_GET_ITEM_ATTRIBUTES;