Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5367631 authored by William Escande's avatar William Escande
Browse files

Change log order for module starting 

Because of recursion, we think we are starting the wrong module in the
error crash
"Can't start stack, last instance: starting Btaa Module" while it's
stuck on hci

Test: None
Bug: 261263171
Change-Id: If7d87a7c98c2190f1db9de84a1c6f5de814d4f2d
parent 89ed1a00

system/gd/module.cc

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,6 @@ Module* ModuleRegistry::Start(const ModuleFactory* module, Thread* thread) { 


  LOG_INFO("Constructing next module");

  Module* instance = module->ctor_();

  last_instance_ = "starting " + instance->ToString();

  set_registry_and_handler(instance, thread);



  LOG_INFO("Starting dependencies of %s", instance->ToString().c_str());
@@ -93,6 +92,7 @@ Module* ModuleRegistry::Start(const ModuleFactory* module, Thread* thread) { 


  LOG_INFO("Finished starting dependencies and calling Start() of %s", instance->ToString().c_str());



  last_instance_ = "starting " + instance->ToString();

  instance->Start();

  start_order_.push_back(module);

  started_modules_[module] = instance;