Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf16a911 authored by Jakub Pawlowski's avatar Jakub Pawlowski
Browse files

Log permission check failure as warning 

Currently when permission check fails, there is no way for users to see
what went wrong. This patch fixes that by providing better log message.

Bug: 28328321
Change-Id: I11f336c6c0560c4be482fefefaf95b70a06a63d6
parent 36cd4ed2

android/app/src/com/android/bluetooth/gatt/GattService.java

+6 −6
Original line number Diff line number Diff line
@@ -803,7 +803,7 @@ public class GattService extends ProfileService { 
            + ", handle=" + handle + ", length=" + data.length);



        if (!permissionCheck(connId, handle)) {

            if (VDBG) Log.d(TAG, "onNotify() - permission check failed!");

            Log.w(TAG, "onNotify() - permission check failed!");

            return;

        }
@@ -1458,7 +1458,7 @@ public class GattService extends ProfileService { 
        }



        if (!permissionCheck(connId, handle)) {

            if (VDBG) Log.d(TAG, "readCharacteristic() - permission check failed!");

            Log.w(TAG, "readCharacteristic() - permission check failed!");

            return;

        }
@@ -1480,7 +1480,7 @@ public class GattService extends ProfileService { 
        }



        if (!permissionCheck(connId, handle)) {

            if (VDBG) Log.d(TAG, "writeCharacteristic() - permission check failed!");

            Log.w(TAG, "writeCharacteristic() - permission check failed!");

            return;

        }
@@ -1499,7 +1499,7 @@ public class GattService extends ProfileService { 
        }



        if (!permissionCheck(connId, handle)) {

            if (VDBG) Log.d(TAG, "readDescriptor() - permission check failed!");

            Log.w(TAG, "readDescriptor() - permission check failed!");

            return;

        }
@@ -1518,7 +1518,7 @@ public class GattService extends ProfileService { 
        }



        if (!permissionCheck(connId, handle)) {

            if (VDBG) Log.d(TAG, "writeDescriptor() - permission check failed!");

            Log.w(TAG, "writeDescriptor() - permission check failed!");

            return;

        }
@@ -1555,7 +1555,7 @@ public class GattService extends ProfileService { 
        }



        if (!permissionCheck(connId, handle)) {

            if (VDBG) Log.d(TAG, "writeDescriptor() - permission check failed!");

            Log.w(TAG, "registerForNotification() - permission check failed!");

            return;

        }