Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc3cfe6f authored by Hui Peng's avatar Hui Peng
Browse files

[Invisalign2] Remove duplicate logic in the following APIs 

Validating the return value of btm_find_dev is not null
has been done in their callers, removing.

- SMP_PasskeyReply
- SMP_ConfirmReply
- SMP_SirkConfirmDeviceReply

Bug: 301661850
Test: atest net_test_stack
Flag: EXEMPT, no-op change
Change-Id: I88981061367640fefb42c995e44c796838e30cb0
parent dcd1cd7e

system/stack/smp/smp_api.cc

+1 −16
Original line number Diff line number Diff line
@@ -32,8 +32,8 @@ 
#include "l2cdefs.h"

#include "os/log.h"

#include "smp_int.h"

#include "stack/btm/btm_dev.h"

#include "stack/include/bt_octets.h"

#include "stack/include/btm_sec_api_types.h"

#include "types/raw_address.h"



/*******************************************************************************
@@ -294,11 +294,6 @@ void SMP_PasskeyReply(const RawAddress& bd_addr, uint8_t res, 
    return;

  }



  if (btm_find_dev(bd_addr) == NULL) {

    LOG_ERROR("no dev CB");

    return;

  }



  if (passkey > BTM_MAX_PASSKEY_VAL || res != SMP_SUCCESS) {

    LOG_WARN("Wrong key len:%d or passkey entry fail", passkey);

    /* send pairing failure */
@@ -346,11 +341,6 @@ void SMP_ConfirmReply(const RawAddress& bd_addr, uint8_t res) { 
    return;

  }



  if (btm_find_dev(bd_addr) == NULL) {

    LOG_ERROR("no dev CB");

    return;

  }



  if (res != SMP_SUCCESS) {

    LOG_WARN("Numeric Comparison fails");

    /* send pairing failure */
@@ -527,11 +517,6 @@ void SMP_SirkConfirmDeviceReply(const RawAddress& bd_addr, uint8_t res) { 
    return;

  }



  if (btm_find_dev(bd_addr) == NULL) {

    LOG_ERROR("No dev CB");

    return;

  }



  tSMP_INT_DATA smp_int_data;

  if (res != SMP_SUCCESS) {

    LOG_WARN("Verification fails");