Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7468ee4 authored by Rongxuan Liu's avatar Rongxuan Liu
Browse files

[le audio] Fix broadcast code padding on assistant side 

According to Core Spec. 5.3, Vol 3, Part C, Sec. 3.2.6.3
The code should be LSB first, with MSB padding bytes when
needed. The source has the fix, but assistant side is missing this.

Tag: #feature
Bug: 270005590
Test: atest BluetoothInstrumentationTests
Test: manual broadcast test with encrypted source
Change-Id: Id068335d05fe2fe3c9cf3990b5458ec97d99e55f
parent f657aa62

android/app/src/com/android/bluetooth/bass_client/BassClientStateMachine.java

+3 −5
Original line number Diff line number Diff line
@@ -1381,11 +1381,9 @@ public class BassClientStateMachine extends StateMachine { 
            log("byte array broadcast Code:" + Arrays.toString(actualPIN));

            log("pinLength:" + actualPIN.length);

            // Broadcast_Code, Fill the PIN code in the Last Position

            // This effectively adds padding zeros to LSB positions when the broadcast code

            // is shorter than 16 octets

            System.arraycopy(

                    actualPIN, 0, res,

                    (BassConstants.PIN_CODE_CMD_LEN - actualPIN.length), actualPIN.length);

            // This effectively adds padding zeros to MSB positions when the broadcast code

            // is shorter than 16 octets, skip the first 2 bytes for opcode and source_id.

            System.arraycopy(actualPIN, 0, res, 2, actualPIN.length);

            log("SET_BCAST_PIN in Bytes");

            BassUtils.printByteArray(res);

        }