Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c341f08e authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Rename fluoride_common_options into bluetooth_cflags" into main

parents 00bc4687 4043a70f

Android.bp

+33 −0
Original line number Diff line number Diff line
@@ -45,6 +45,39 @@ filegroup { 
    ],

}



// This default contains properties that should be common to all the cc targets

// developed by the Bluetooth team.

//

// Be careful when adding new properties here:

//  - The option should not impact negatively any target, for example "-Wno-*"

//    options should not be added here but instead on every targets needing

//    them to avoid allowing adding new warnings in targets that didn't contained

//    them (you can use the bpmodify tool to ease the work of adding this warning

//    everywhere) and also allows cleaning them one at a time.

//

//  - The option should apply to all the c/c++ code developed by the Bluetooth team:

//    test, tools, fuzzers, etc, not only production targets, if you need to add an option

//    for a subset of Bluetooth cc targets you should look at the defaults including this

//    defaults like "fluoride_defaults" and "gd_defaults".

//

//  - Try to keep the name as precise as possible to document to the dependent of what

//    this default contains. This also means that if you add a new option that isn't

//    documented by the name of this default, rename it.

//

//  - Try avoiding adding option that would not fit "future" targets, for exemple dependencies,

//    even if every modules of Bluetooth depends on a specific dependency it should be left out

//    from this default to not push it for future targets that might not need it.

cc_defaults {

    name: "bluetooth_cflags",

    cflags: [

        "-Wall",

        "-Werror",

        "-Wextra",

        // there are too many unused parameters in all the code.

        "-Wno-unused-parameter",

    ],

}



// Address Sanitizer is flaky on Android x86_64 binaries but it's not on x86

// binaries.

// This default workaround the x86_64 ASAN flakyness by running 32bit binaries

system/audio_a2dp_hw/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -9,7 +9,7 @@ package { 


cc_defaults {

    name: "audio_a2dp_hw_defaults",

    defaults: ["fluoride_common_options"],

    defaults: ["bluetooth_cflags"],

    shared_libs: ["libchrome"],

    include_dirs: [

        "packages/modules/Bluetooth/system",

system/audio_bluetooth_hw/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ package { 


cc_defaults {

    name: "audio_bluetooth_hw_defaults",

    defaults: ["fluoride_common_options"],

    defaults: ["bluetooth_cflags"],

    cflags: [

        // suppress the warning in stream_apis.cc

        "-Wno-sign-compare",

system/audio_hearing_aid_hw/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -9,7 +9,7 @@ package { 


cc_defaults {

    name: "audio_hearing_aid_hw_defaults",

    defaults: ["fluoride_common_options"],

    defaults: ["bluetooth_cflags"],

    shared_libs: ["libchrome"],

    include_dirs: [

        "packages/modules/Bluetooth/system",

system/btif/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ btifCommonIncludes = [ 


cc_library {

    name: "libstatslog_bt",

    defaults: ["fluoride_common_options"],

    defaults: ["bluetooth_cflags"],

    host_supported: true,

    generated_sources: ["statslog_bt.cpp"],

    generated_headers: ["statslog_bt.h"],