Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c300542b authored by Hansong Zhang's avatar Hansong Zhang Committed by Andre Eisenbach
Browse files

AVRCP: Verify SetBrowsedPlayer player ID 

IUT should reject the invalid SetBrowsedPlayer command sent from PTS.

Bug: 79377126
Test: PTS AVRCP/TG/MPS/BI-02-C
Change-Id: I2afde442e3b3563f4a1a37e2914c9b16fe07e8fc
parent 995cbbe3

system/profile/avrcp/device.cc

+7 −2
Original line number Diff line number Diff line
@@ -1009,8 +1009,13 @@ void Device::SetBrowsedPlayerResponse( 
  DEVICE_VLOG(2) << __func__ << ": success=" << success << " root_id=\""

                 << root_id << "\" num_items=" << num_items;



  // TODO (apanicke): Check success. Right now this is ok since it will

  // always succeed since we only have one player in the media layer.

  if (!success) {

    auto response = SetBrowsedPlayerResponseBuilder::MakeBuilder(

        Status::INVALID_PLAYER_ID, 0x0000, num_items, 0, "");

    send_message(label, true, std::move(response));

    return;

  }



  curr_browsed_player_id_ = pkt->GetPlayerId();



  // Clear the path and push the new root.