Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c28af6fe authored by William Escande's avatar William Escande
Browse files

AppScanStatsTest: only call tested class

Bug: 295237486
Test: atest AppScanStatsTest
Change-Id: I041e04f8c2889ac4d217422196fca46571ca7374
parent ef2b3c6b
Loading
Loading
Loading
Loading
+17 −17
Original line number Diff line number Diff line
@@ -17,21 +17,21 @@
package com.android.bluetooth.gatt;

import static com.google.common.truth.Truth.assertThat;

import static org.mockito.Mockito.mock;

import android.bluetooth.le.ScanFilter;
import android.bluetooth.le.ScanSettings;
import android.content.Context;
import android.location.LocationManager;
import android.os.BatteryStatsManager;
import android.os.WorkSource;

import androidx.test.InstrumentationRegistry;
import androidx.test.filters.SmallTest;
import androidx.test.rule.ServiceTestRule;
import androidx.test.runner.AndroidJUnit4;

import com.android.bluetooth.TestUtils;
import com.android.bluetooth.btservice.AdapterService;
import com.android.internal.app.IBatteryStats;

import org.junit.After;
import org.junit.Before;
@@ -51,16 +51,19 @@ import java.util.List;
@RunWith(AndroidJUnit4.class)
public class AppScanStatsTest {

    private GattService mService;

    @Rule
    public final ServiceTestRule mServiceRule = new ServiceTestRule();

    @Mock
    private ContextMap map;

    @Mock
    private AdapterService mAdapterService;
    @Mock private GattService mMockGatt;
    @Mock private AdapterService mAdapterService;

    // BatteryStatsManager is final and cannot be mocked with regular mockito, so just mock the
    // underlying binder calls.
    final BatteryStatsManager mBatteryStatsManager =
            new BatteryStatsManager(mock(IBatteryStats.class));

    @Before
    public void setUp() throws Exception {
@@ -69,17 +72,14 @@ public class AppScanStatsTest {
        TestUtils.setAdapterService(mAdapterService);

        TestUtils.mockGetSystemService(
                mAdapterService, Context.LOCATION_SERVICE, LocationManager.class);

        mService = new GattService(InstrumentationRegistry.getTargetContext());
        mService.start();
                mMockGatt,
                Context.BATTERY_STATS_SERVICE,
                BatteryStatsManager.class,
                mBatteryStatsManager);
    }

    @After
    public void tearDown() throws Exception {
        mService.stop();
        mService = null;

        TestUtils.clearAdapterService(mAdapterService);
    }

@@ -88,10 +88,10 @@ public class AppScanStatsTest {
        String name = "appName";
        WorkSource source = null;

        AppScanStats appScanStats = new AppScanStats(name, source, map, mService);
        AppScanStats appScanStats = new AppScanStats(name, source, map, mMockGatt);

        assertThat(appScanStats.mContextMap).isEqualTo(map);
        assertThat(appScanStats.mGattService).isEqualTo(mService);
        assertThat(appScanStats.mGattService).isEqualTo(mMockGatt);

        assertThat(appScanStats.isScanning()).isEqualTo(false);
    }
@@ -101,7 +101,7 @@ public class AppScanStatsTest {
        String name = "appName";
        WorkSource source = null;

        AppScanStats appScanStats = new AppScanStats(name, source, map, mService);
        AppScanStats appScanStats = new AppScanStats(name, source, map, mMockGatt);

        ScanSettings settings = new ScanSettings.Builder().build();
        List<ScanFilter> filters = new ArrayList<>();