Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit befbb8df authored by William Escande's avatar William Escande
Browse files

ErrorProne: Enforce & fix EmptyBlockTag 

See https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags

Bug: 344658662
Test: m BluetoothInstrumentationTests
Flag: Exempt Build and test only
Change-Id: I319ac82d77fc2afa6604575473fbe0bddd152bf8
parent 9aa56293

android/app/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -323,6 +323,7 @@ android_app { 
            "-Xep:AlmostJavadoc:ERROR",

            "-Xep:BadImport:ERROR",

            "-Xep:ClassCanBeStatic:ERROR",

            "-Xep:EmptyBlockTag:ERROR",

            "-Xep:InlineMeInliner:ERROR",

            "-Xep:InvalidBlockTag:ERROR",

            "-Xep:InvalidParam:ERROR",

android/app/src/com/android/bluetooth/a2dpsink/A2dpSinkNativeInterface.java

+2 −11
Original line number Diff line number Diff line
@@ -116,7 +116,6 @@ public class A2dpSinkNativeInterface { 
     *

     * <p>Sending null for the active device will make no device active.

     *

     * @param device

     * @return True if the active device request has been scheduled

     */

    public boolean setActiveDevice(BluetoothDevice device) {
@@ -130,20 +129,12 @@ public class A2dpSinkNativeInterface { 
        return setActiveDeviceNative(address);

    }



    /**

     * Inform A2DP decoder of the current audio focus

     *

     * @param focusGranted

     */

    /** Inform A2DP decoder of the current audio focus */

    public void informAudioFocusState(int focusGranted) {

        informAudioFocusStateNative(focusGranted);

    }



    /**

     * Inform A2DP decoder the desired audio gain

     *

     * @param gain

     */

    /** Inform A2DP decoder the desired audio gain */

    public void informAudioTrackGain(float gain) {

        informAudioTrackGainNative(gain);

    }

android/app/src/com/android/bluetooth/bas/BatteryService.java

+1 −5
Original line number Diff line number Diff line
@@ -231,11 +231,7 @@ public class BatteryService extends ProfileService { 
        return true;

    }



    /**

     * Gets devices that battery service is connected.

     *

     * @return

     */

    /** Gets devices that battery service is connected. */

    @RequiresPermission(android.Manifest.permission.BLUETOOTH_PRIVILEGED)

    public List<BluetoothDevice> getConnectedDevices() {

        enforceCallingOrSelfPermission(

android/app/src/com/android/bluetooth/gatt/GattNativeInterface.java

+2 −12
Original line number Diff line number Diff line
@@ -519,12 +519,7 @@ public class GattNativeInterface { 
        gattClientWriteDescriptorNative(connId, handle, authReq, value);

    }



    /**

     * Execute a reliable write transaction

     *

     * @param connId

     * @param execute

     */

    /** Execute a reliable write transaction */

    public void gattClientExecuteWrite(int connId, boolean execute) {

        gattClientExecuteWriteNative(connId, execute);

    }
@@ -535,12 +530,7 @@ public class GattNativeInterface { 
        gattClientRegisterForNotificationsNative(clientIf, address, handle, enable);

    }



    /**

     * Read the RSSI for a connected remote device

     *

     * @param clientIf

     * @param address

     */

    /** Read the RSSI for a connected remote device */

    public void gattClientReadRemoteRssi(int clientIf, String address) {

        gattClientReadRemoteRssiNative(clientIf, address);

    }

android/app/src/com/android/bluetooth/hearingaid/HearingAidNativeInterface.java

+1 −5
Original line number Diff line number Diff line
@@ -113,11 +113,7 @@ public class HearingAidNativeInterface { 
        return addToAcceptlistNative(getByteAddress(device));

    }



    /**

     * Sets the HearingAid volume

     *

     * @param volume

     */

    /** Sets the HearingAid volume */

    @VisibleForTesting(visibility = VisibleForTesting.Visibility.PACKAGE)

    public void setVolume(int volume) {

        setVolumeNative(volume);