Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9abcc1a authored by chaoyu.x.wu's avatar chaoyu.x.wu Committed by Jakub Pawlowski
Browse files

Fix the BLE connection failure with some mice 

If enable the "connection parameters update" during GATT discovery,
it may cause some device connection failure due to connection timeout.
Since the the "connection parameter update" is enabled again when GATT
discovery completed, remove the enable of "connection parameter update"
after SMP complete to fix the issue.

This issue was already fixed in commit e3466c35, but then it was
re-introduced in commit 29c725d4, which also removed comment explaining
the issue, added back in this patch.

Bug: 29060797
Change-Id: I42b0b36056821c30d887484e22bfcbd04ea7ca03
(cherry picked from commit 1ec17e06c73c67592aeda29e0aaa03580fdecce9)
parent db3ce3ba

system/stack/smp/smp_act.c

+5 −4
Original line number Diff line number Diff line
@@ -1502,8 +1502,6 @@ void smp_pairing_cmpl(tSMP_CB *p_cb, tSMP_INT_DATA *p_data) 
{

    if (p_cb->total_tx_unacked == 0)

    {

        /* update connection parameter to remote preferred */

        L2CA_EnableUpdateBleConnParams(p_cb->pairing_bda, TRUE);

        /* process the pairing complete */

        smp_proc_pairing_cmpl(p_cb);

    }
@@ -1542,8 +1540,11 @@ void smp_idle_terminate(tSMP_CB *p_cb, tSMP_INT_DATA *p_data) 
*******************************************************************************/

void smp_fast_conn_param(tSMP_CB *p_cb, tSMP_INT_DATA *p_data)

{

    /* disable connection parameter update */

    L2CA_EnableUpdateBleConnParams(p_cb->pairing_bda, FALSE);

    /* Disable L2CAP connection parameter updates while bonding since

       some peripherals are not able to revert to fast connection parameters

       during the start of service discovery. Connection paramter updates

       get enabled again once service discovery completes. */

    L2CA_EnableUpdateBleConnParams(p_cb->pairing_bda, false);

}



/*******************************************************************************