Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8fdac5a authored by Jakub Tyszkowski's avatar Jakub Tyszkowski
Browse files

LeAudio: Fix the confusing logs 

 - on state machine timeout debug-print the group details before
   altering the group state,
 - fix the misleading print about using Uni-Directional CIS, when in
   reality Bi-Directional CIS is used.

Bug: 361518110
Test: atest bluetooth_le_audio_client_test
Flag: EXEMPT; no functional change
Change-Id: I47d28fac1801dfe9521c5cad85496da41d33eb7c
parent a411fa9a

system/bta/le_audio/client.cc

+1 −1
Original line number Diff line number Diff line
@@ -545,9 +545,9 @@ public: 
            "target state: {}, check_if_recovery_needed: {}",

            group_id, ToString(group->GetState()), ToString(group->GetTargetState()),

            check_if_recovery_needed);

    group->PrintDebugState();

    group->SetTargetState(AseState::BTA_LE_AUDIO_ASE_STATE_IDLE);

    group->ClearAllCises();

    group->PrintDebugState();



    /* There is an issue with a setting up stream or any other operation which

     * are gatt operations. It means peer is not responsible. Lets close ACL

system/bta/le_audio/device_groups.cc

+8 −4
Original line number Diff line number Diff line
@@ -1314,14 +1314,16 @@ bool LeAudioDeviceGroup::CigConfiguration::AssignCisIds(LeAudioDevice* leAudioDe 
         */

        cis_id = GetFirstFreeCisId(CisType::CIS_TYPE_BIDIRECTIONAL);

        if (cis_id == kInvalidCisId) {

          log::error("Unable to get free Uni-Directional Sink CIS ID");

          log::error("Unable to get free Bi-Directional CIS ID for Sink ASE");

          return false;

        }

        log::info("ASE ID: {}, assigned Bi-Directional CIS ID: {} for Sink ASE", ase->id, cis_id);

      } else {

        log::info("ASE ID: {}, assigned Uni-Directional CIS ID: {} for Sink ASE", ase->id, cis_id);

      }



      ase->cis_id = cis_id;

      cises[cis_id].addr = leAudioDevice->address_;

      log::info("ASE ID: {}, assigned Uni-Directional Sink CIS ID: {}", ase->id, ase->cis_id);

      continue;

    }
@@ -1342,14 +1344,16 @@ bool LeAudioDeviceGroup::CigConfiguration::AssignCisIds(LeAudioDevice* leAudioDe 
              "bi-directional available");

      cis_id = GetFirstFreeCisId(CisType::CIS_TYPE_BIDIRECTIONAL);

      if (cis_id == kInvalidCisId) {

        log::error("Unable to get free Uni-Directional Source CIS ID");

        log::error("Unable to get free Bi-Directional CIS ID for Source ASE");

        return false;

      }

      log::info("ASE ID: {}, assigned Bi-Directional CIS ID: {} for Source ASE", ase->id, cis_id);

    } else {

      log::info("ASE ID: {}, assigned Uni-Directional CIS ID: {} for Source ASE", ase->id, cis_id);

    }



    ase->cis_id = cis_id;

    cises[cis_id].addr = leAudioDevice->address_;

    log::info("ASE ID: {}, assigned Uni-Directional Source CIS ID: {}", ase->id, ase->cis_id);

  }



  return true;