Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b80ed6aa authored by Martin Geisler's avatar Martin Geisler Committed by Automerger Merge Worker
Browse files

pdl: remove “checksum start precedes checksum field” lint am: fbc2d570 

Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2151418



Change-Id: Idd626d44254064cee3e50ea34b09f792dc36493b
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents a4290ae6 fbc2d570

tools/pdl/src/lint.rs

+19 −14
Original line number Diff line number Diff line
@@ -687,20 +687,6 @@ fn lint_checksum( 
                // is checked.

                None => (),

            };

            // Check declaration order of checksum field.

            match field_decl.and_then(|f| f.0.first()) {

                Some(decl) if decl.loc().start > checksum_loc.start => result.push(

                    Diagnostic::error()

                        .with_message("invalid checksum start declaration")

                        .with_labels(vec![

                            checksum_loc

                                .primary()

                                .with_message("checksum start precedes checksum field"),

                            decl.loc().secondary().with_message("checksum field is declared here"),

                        ]),

                ),

                _ => (),

            }

        }

        Some(field) => result.push(

            Diagnostic::error()
@@ -1290,4 +1276,23 @@ mod test { 
        let result = grammar.lint();

        assert!(!result.diagnostics.is_empty());

    }



    #[test]

    fn test_packet_checksum_start() {

        let mut db = SourceDatabase::new();

        let grammar = grammar!(

            &mut db,

            r#"

              little_endian_packets

              checksum Checksum : 8 "Checksum"

              packet P {

                  _checksum_start_(crc),

                  a: 16,

                  crc: Checksum,

              }

            "#

        );

        let result = grammar.lint();

        assert!(dbg!(result.diagnostics).is_empty());

    }

}