Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b691839a authored by Hui Kang's avatar Hui Kang Committed by Automerger Merge Worker
Browse files

Merge "Revert "Revert^2 "Adds screen on/off event counter""" am: 7f89fd22 

Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2572430



Change-Id: Ie5ed09f11ac53373d7467d43c9cdada4be4efc44
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 5d3574de 7f89fd22

android/app/src/com/android/bluetooth/gatt/AppScanStats.java

+0 −10
Original line number Diff line number Diff line
@@ -394,15 +394,6 @@ import java.util.Objects; 
        }

    }



    @GuardedBy("sLock")

    private static void recordScreenOnOffMetrics(boolean isScreenOn) {

        if (isScreenOn) {

            MetricsLogger.getInstance().cacheCount(BluetoothProtoEnums.SCREEN_ON_EVENT, 1);

        } else {

            MetricsLogger.getInstance().cacheCount(BluetoothProtoEnums.SCREEN_OFF_EVENT, 1);

        }

    }



    private static int getScanWeight(int scanMode) {

        switch (scanMode) {

            case ScanSettings.SCAN_MODE_OPPORTUNISTIC:
@@ -448,7 +439,6 @@ import java.util.Objects; 
                recordScanRadioDurationMetrics();

                sRadioStartTime = SystemClock.elapsedRealtime();

            }

            recordScreenOnOffMetrics(isScreenOn);

            sIsScreenOn = isScreenOn;

        }

    }

android/app/tests/unit/src/com/android/bluetooth/gatt/ScanManagerTest.java

+3 −22
Original line number Diff line number Diff line
@@ -37,7 +37,6 @@ import static org.mockito.Mockito.atMost; 
import static org.mockito.Mockito.doReturn;

import static org.mockito.Mockito.eq;

import static org.mockito.Mockito.never;

import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;

import static org.mockito.Mockito.when;
@@ -1055,6 +1054,7 @@ public class ScanManagerTest { 
        final boolean isFiltered = true;

        // Turn on screen

        sendMessageWaitForProcessed(createScreenOnOffMessage(true));

        verify(mMetricsLogger, never()).cacheCount(anyInt(), anyLong());

        Mockito.clearInvocations(mMetricsLogger);

        // Create scan client

        ScanClient client = createScanClient(0, isFiltered, SCAN_MODE_LOW_POWER);
@@ -1085,6 +1085,7 @@ public class ScanManagerTest { 
        final boolean isFiltered = true;

        // Turn on screen

        sendMessageWaitForProcessed(createScreenOnOffMessage(true));

        verify(mMetricsLogger, never()).cacheCount(anyInt(), anyLong());

        Mockito.clearInvocations(mMetricsLogger);

        // Create scan client

        ScanClient client = createScanClient(0, isFiltered, SCAN_MODE_LOW_POWER);
@@ -1135,6 +1136,7 @@ public class ScanManagerTest { 
        final boolean isFiltered = true;

        // Turn on screen

        sendMessageWaitForProcessed(createScreenOnOffMessage(true));

        verify(mMetricsLogger, never()).cacheCount(anyInt(), anyLong());

        Mockito.clearInvocations(mMetricsLogger);

        // Create scan clients with different duty cycles

        ScanClient client = createScanClient(0, isFiltered, SCAN_MODE_LOW_POWER);
@@ -1215,25 +1217,4 @@ public class ScanManagerTest { 
            Mockito.clearInvocations(mMetricsLogger);

        }

    }



    @Test

    public void testMetricsScreenOnOff() {

        // Turn off screen initially

        sendMessageWaitForProcessed(createScreenOnOffMessage(false));

        Mockito.clearInvocations(mMetricsLogger);

        // Turn on screen

        sendMessageWaitForProcessed(createScreenOnOffMessage(true));

        verify(mMetricsLogger, never()).cacheCount(

                eq(BluetoothProtoEnums.SCREEN_OFF_EVENT), anyLong());

        verify(mMetricsLogger, times(1)).cacheCount(

                eq(BluetoothProtoEnums.SCREEN_ON_EVENT), anyLong());

        Mockito.clearInvocations(mMetricsLogger);

        // Turn off screen

        sendMessageWaitForProcessed(createScreenOnOffMessage(false));

        verify(mMetricsLogger, never()).cacheCount(

                eq(BluetoothProtoEnums.SCREEN_ON_EVENT), anyLong());

        verify(mMetricsLogger, times(1)).cacheCount(

                eq(BluetoothProtoEnums.SCREEN_OFF_EVENT), anyLong());

        Mockito.clearInvocations(mMetricsLogger);

    }

}