Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4d77324 authored by Sungsoo Lim's avatar Sungsoo Lim
Browse files

Make Metadata.equals() faster 

Since it already compares all other fields, we don't need to compare
the image bitmap.

Bug: 247784807
Test: atest MetadataTest
Tag: #refactor
Change-Id: I56a31a3e35613760e469355b4e77d3210af1ce36
parent 3358635a

android/app/src/com/android/bluetooth/audio_util/helpers/Metadata.java

+4 −2
Original line number Diff line number Diff line
@@ -57,19 +57,21 @@ public class Metadata implements Cloneable { 
        if (!(o instanceof Metadata)) return false;



        final Metadata m = (Metadata) o;

        if (!Objects.equals(mediaId, m.mediaId)) return false;

        if (!Objects.equals(title, m.title)) return false;

        if (!Objects.equals(artist, m.artist)) return false;

        if (!Objects.equals(album, m.album)) return false;

        if (!Objects.equals(trackNum, m.trackNum)) return false;

        if (!Objects.equals(numTracks, m.numTracks)) return false;

        if (!Image.sameAs(image, m.image)) return false;

        if (!Objects.equals(genre, m.genre)) return false;

        if (!Objects.equals(duration, m.duration)) return false;

        return true;

    }



    @Override

    public int hashCode() {

        // Do not hash the Image as it does not implement hashCode

        return Objects.hash(title, artist, album, trackNum, numTracks, image);

        return Objects.hash(mediaId, title, artist, album, trackNum, numTracks, genre, duration);

    }



    @Override