Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae001790 authored by Chris Manton's avatar Chris Manton
Browse files

Properly use tHCI_STATUS and hci error code equivalence 

These values are overloaded for both status and reason.

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run

Change-Id: I9f6675707d67811468aab66d0515d68c1cc83ab3
parent 3728ca47

system/bta/dm/bta_dm_act.cc

+2 −2
Original line number Diff line number Diff line
@@ -2183,7 +2183,7 @@ static void bta_dm_local_name_cback(UNUSED_ATTR void* p_name) { 
}



static void handle_role_change(const RawAddress& bd_addr, uint8_t new_role,

                               uint8_t hci_status) {

                               tHCI_STATUS hci_status) {

  tBTA_DM_PEER_DEVICE* p_dev = bta_dm_find_peer_device(bd_addr);

  if (!p_dev) {

    LOG_WARN(
@@ -2230,7 +2230,7 @@ static void handle_role_change(const RawAddress& bd_addr, uint8_t new_role, 
}



void BTA_dm_report_role_change(const RawAddress bd_addr, uint8_t new_role,

                               uint8_t hci_status) {

                               tHCI_STATUS hci_status) {

  do_in_main_thread(

      FROM_HERE, base::Bind(handle_role_change, bd_addr, new_role, hci_status));

}

system/bta/include/bta_dm_acl.h

+2 −1
Original line number Diff line number Diff line
@@ -19,11 +19,12 @@ 
#include <cstdint>



#include "stack/include/bt_types.h"

#include "stack/include/hci_error_code.h"

#include "types/bt_transport.h"

#include "types/raw_address.h"



void BTA_dm_acl_up(const RawAddress bd_addr, tBT_TRANSPORT transport);

void BTA_dm_acl_down(const RawAddress bd_addr, tBT_TRANSPORT transport);

void BTA_dm_report_role_change(const RawAddress bd_addr, uint8_t new_role,

                               uint8_t hci_status);

                               tHCI_STATUS hci_status);

void BTA_dm_notify_remote_features_complete(const RawAddress bd_addr);

system/bta/sys/bta_sys.h

+2 −1
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
#include "bt_common.h"

#include "bt_target.h"

#include "osi/include/alarm.h"

#include "stack/include/hci_error_code.h"



#include <base/logging.h>

#include <base/threading/thread.h>
@@ -232,7 +233,7 @@ extern void bta_sys_chg_ssr_config(uint8_t id, uint8_t app_id, 


extern void bta_sys_role_chg_register(tBTA_SYS_CONN_CBACK* p_cback);

extern void bta_sys_notify_role_chg(const RawAddress& peer_addr,

                                    uint8_t new_role, uint8_t hci_status);

                                    uint8_t new_role, tHCI_STATUS hci_status);

extern void bta_sys_collision_register(uint8_t bta_id,

                                       tBTA_SYS_CONN_CBACK* p_cback);

extern void bta_sys_notify_collision(const RawAddress& peer_addr);

system/bta/sys/bta_sys_conn.cc

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ void bta_sys_ssr_cfg_register(tBTA_SYS_SSR_CFG_CBACK* p_cback) { 
 *

 ******************************************************************************/

void bta_sys_notify_role_chg(const RawAddress& peer_addr, uint8_t new_role,

                             uint8_t hci_status) {

                             tHCI_STATUS hci_status) {

  LOG_DEBUG("Role changed peer:%s new_role:%s hci_status:%s",

            PRIVATE_ADDRESS(peer_addr), RoleText(new_role).c_str(),

            hci_error_code_text(hci_status).c_str());

system/main/shim/l2c_api.cc

+3 −2
Original line number Diff line number Diff line
@@ -595,8 +595,9 @@ bool L2CA_ReadRemoteVersion(const RawAddress& addr, uint8_t* lmp_version, 
}



static void on_sco_disconnect(uint16_t handle, uint8_t reason) {

  GetGdShimHandler()->Post(

      base::BindOnce(base::IgnoreResult(&btm_sco_removed), handle, reason));

  GetGdShimHandler()->Post(base::BindOnce(base::IgnoreResult(&btm_sco_removed),

                                          handle,

                                          static_cast<tHCI_REASON>(reason)));

}



void L2CA_UseLegacySecurityModule() {