Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a55b63ca authored by Jakub Tyszkowski's avatar Jakub Tyszkowski
Browse files

LeAudio: Fix flaky unit tests 

Bug: 295574405
Test: atest --host bluetooth_le_audio_client_test --disable-upload-result --minimal-build --no-metrics
Change-Id: I6de878cded1768f1bb37fea669c601ea1b2208df
parent 21b65e47

system/bta/le_audio/le_audio_client_test.cc

+47 −2
Original line number Diff line number Diff line
@@ -1785,6 +1785,7 @@ class UnicastTestNoInit : public Test { 
  void LocalAudioSourceSuspend(void) {

    ASSERT_NE(unicast_source_hal_cb_, nullptr);

    unicast_source_hal_cb_->OnAudioSuspend();

    SyncOnMainLoop();

  }



  void LocalAudioSourceResume(bool expected_confirmation = true) {
@@ -1807,6 +1808,7 @@ class UnicastTestNoInit : public Test { 
  void LocalAudioSinkSuspend(void) {

    ASSERT_NE(unicast_sink_hal_cb_, nullptr);

    unicast_sink_hal_cb_->OnAudioSuspend();

    SyncOnMainLoop();

  }



  void LocalAudioSinkResume(void) {
@@ -1851,6 +1853,7 @@ class UnicastTestNoInit : public Test { 
                            },

                            unicast_sink_hal_cb_));

    }

    SyncOnMainLoop();

  }



  void StopStreaming(int group_id, bool suspend_source = false) {
@@ -1873,6 +1876,7 @@ class UnicastTestNoInit : public Test { 
      ASSERT_NE(unicast_sink_hal_cb_, nullptr);

      unicast_sink_hal_cb_->OnAudioSuspend();

    }

    SyncOnMainLoop();

  }



  void set_sample_database(uint16_t conn_id, RawAddress addr,
@@ -2955,6 +2959,7 @@ TEST_F(UnicastTestHealthStatus, 
  Mock::VerifyAndClearExpectations(&mock_audio_hal_client_callbacks_);



  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  auto health_status = LeAudioHealthStatus::Get();
@@ -3718,6 +3723,7 @@ TEST_F(UnicastTest, RemoveNodeWhileStreaming) { 
  LeAudioClient::Get()->SetCcidInformation(gmcs_ccid, 4 /* Media */);

  LeAudioClient::Get()->SetCcidInformation(gtbs_ccid, 2 /* Phone */);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  types::BidirectionalPair<std::vector<uint8_t>> ccids = {.sink = {gmcs_ccid},

                                                          .source = {}};
@@ -4217,6 +4223,7 @@ TEST_F(UnicastTest, RemoveWhileStreaming) { 
  LeAudioClient::Get()->SetCcidInformation(gmcs_ccid, 4 /* Media */);

  LeAudioClient::Get()->SetCcidInformation(gtbs_ccid, 2 /* Phone */);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  types::BidirectionalPair<std::vector<uint8_t>> ccids = {.sink = {gmcs_ccid},

                                                          .source = {}};
@@ -4297,6 +4304,7 @@ TEST_F(UnicastTest, DisconnecteWhileAlmostStreaming) { 
  LeAudioClient::Get()->SetCcidInformation(gmcs_ccid, 4 /* Media */);

  LeAudioClient::Get()->SetCcidInformation(gtbs_ccid, 2 /* Phone */);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  types::BidirectionalPair<std::vector<uint8_t>> ccids = {.sink = {gmcs_ccid},

                                                          .source = {}};
@@ -4376,6 +4384,7 @@ TEST_F(UnicastTest, EarbudsTwsStyleStreaming) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);
@@ -4406,6 +4415,7 @@ TEST_F(UnicastTest, EarbudsTwsStyleStreaming) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, OnDestroyed()).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, OnDestroyed()).Times(1);

  LeAudioClient::Get()->GroupSetActive(bluetooth::groups::kGroupUnknown);

  SyncOnMainLoop();

  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);

}
@@ -4441,6 +4451,7 @@ TEST_F(UnicastTest, SpeakerFailedConversationalStreaming) { 


  // Audio sessions are started only when device gets active

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  /* Nothing to do - expect no crash */

}
@@ -4474,6 +4485,7 @@ TEST_F(UnicastTest, SpeakerStreaming) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);
@@ -4504,6 +4516,7 @@ TEST_F(UnicastTest, SpeakerStreaming) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, OnDestroyed()).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, OnDestroyed()).Times(1);

  LeAudioClient::Get()->GroupSetActive(bluetooth::groups::kGroupUnknown);

  SyncOnMainLoop();

  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);

}
@@ -4551,6 +4564,7 @@ TEST_F(UnicastTest, SpeakerStreamingNonDefault) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_ASSISTANT, AUDIO_CONTENT_TYPE_UNKNOWN, group_id);
@@ -4581,12 +4595,14 @@ TEST_F(UnicastTest, SpeakerStreamingNonDefault) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, OnDestroyed()).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, OnDestroyed()).Times(1);

  LeAudioClient::Get()->GroupSetActive(bluetooth::groups::kGroupUnknown);

  SyncOnMainLoop();

  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);



  /* When session is closed, the hal client mocks are freed - get new ones */

  SetUpMockAudioHal();

  /* Expect the previous release to clear the old audio session metadata */

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();

  EXPECT_CALL(mock_state_machine_,

              StartStream(_, types::LeAudioContextType::VOICEASSISTANTS, _, _))

      .Times(0);
@@ -4621,6 +4637,7 @@ TEST_F(UnicastTest, SpeakerStreamingAutonomousRelease) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);
@@ -4682,6 +4699,8 @@ TEST_F(UnicastTest, TwoEarbudsStreaming) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);



  StartStreaming(AUDIO_USAGE_VOICE_COMMUNICATION, AUDIO_CONTENT_TYPE_SPEECH,
@@ -4719,6 +4738,8 @@ TEST_F(UnicastTest, TwoEarbudsStreaming) { 
  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Stop()).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, OnDestroyed()).Times(1);

  LeAudioClient::Get()->GroupSetActive(bluetooth::groups::kGroupUnknown);

  SyncOnMainLoop();



  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);

}
@@ -4863,6 +4884,7 @@ TEST_F(UnicastTest, TwoEarbudsStreamingContextSwitchReconfigure) { 
  LeAudioClient::Get()->SetCcidInformation(gmcs_ccid, 4 /* Media */);

  LeAudioClient::Get()->SetCcidInformation(gtbs_ccid, 2 /* Phone */);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  types::BidirectionalPair<std::vector<uint8_t>> ccids = {.sink = {gmcs_ccid},

                                                          .source = {}};
@@ -4946,6 +4968,7 @@ TEST_F(UnicastTest, TwoEarbuds2ndLateConnect) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5012,6 +5035,7 @@ TEST_F(UnicastTest, TwoEarbuds2ndReleaseAseRemoveAvailableContextAndBack) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5115,6 +5139,7 @@ TEST_F(UnicastTest, StartStream_AvailableContextTypeNotifiedLater) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5176,6 +5201,7 @@ TEST_F(UnicastTest, ModifyContextTypeOnDeviceA_WhileDeviceB_IsDisconnected) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5287,6 +5313,7 @@ TEST_F(UnicastTest, StartStreamToUnsupportedContextTypeUsingUnspecified) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5372,6 +5399,7 @@ TEST_F(UnicastTest, 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5436,6 +5464,7 @@ TEST_F(UnicastTest, StartStreamToSupportedContextTypeThenMixUnavailable) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  ON_CALL(mock_csis_client_module_, GetDesiredSize(group_id))

      .WillByDefault(Invoke([&](int group_id) { return 2; }));
@@ -5564,6 +5593,7 @@ TEST_F(UnicastTest, TwoEarbuds2ndDisconnected) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);

  auto group = streaming_groups.at(group_id);
@@ -5652,6 +5682,7 @@ TEST_F(UnicastTest, TwoEarbudsStreamingProfileDisconnect) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);
@@ -5717,6 +5748,7 @@ TEST_F(UnicastTest, TwoEarbudsStreamingProfileDisconnectStreamStopTimeout) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);
@@ -5875,6 +5907,7 @@ TEST_F(UnicastTest, MicrophoneAttachToCurrentMediaScenario) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  // When the local audio source resumes we have no knowledge of recording

  EXPECT_CALL(mock_state_machine_,
@@ -5946,9 +5979,9 @@ TEST_F(UnicastTest, MicrophoneAttachToCurrentMediaScenario) { 
                       client->GroupSetActive(bluetooth::groups::kGroupUnknown);

                     },

                     LeAudioClient::Get()));

  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);



  SyncOnMainLoop();



  Mock::VerifyAndClearExpectations(&mock_le_audio_source_hal_client_);

}



/* When a certain context is unavailable and not supported we should stream
@@ -5996,6 +6029,7 @@ TEST_F(UnicastTest, UpdateNotSupportedContextTypeUnspecifiedAvailable) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_NOTIFICATION_TELEPHONY_RINGTONE,

                 AUDIO_CONTENT_TYPE_UNKNOWN, group_id);
@@ -6069,6 +6103,7 @@ TEST_F(UnicastTest, UpdateMultipleBidirContextTypes) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  // When the local audio sink resumes expect only LIVE context

  types::BidirectionalPair<types::AudioContexts> contexts = {
@@ -6216,6 +6251,7 @@ TEST_F(UnicastTest, MusicDuringCallContextTypes) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  // 1) Start with the call first

  // -----------------------------
@@ -6383,6 +6419,8 @@ TEST_F(UnicastTest, StartNotAvailableSupportedContextType) { 
      .Times(0);



  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_EMERGENCY, AUDIO_CONTENT_TYPE_UNKNOWN, group_id,

                 AUDIO_SOURCE_INVALID, false, false);
@@ -6441,6 +6479,8 @@ TEST_F(UnicastTest, StartNotAvailableUnsupportedContextTypeUnspecifiedUnavail) { 
      .Times(0);



  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_EMERGENCY, AUDIO_CONTENT_TYPE_UNKNOWN, group_id,

                 AUDIO_SOURCE_INVALID, false, false);
@@ -6495,6 +6535,8 @@ TEST_F(UnicastTest, StartNotAvailableUnsupportedContextTypeUnspecifiedAvail) { 
      .Times(1);



  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_EMERGENCY, AUDIO_CONTENT_TYPE_UNKNOWN, group_id);



  SyncOnMainLoop();
@@ -6539,6 +6581,7 @@ TEST_F(UnicastTest, NotifyAboutGroupTunrnedIdleEnabled) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_NOTIFICATION_TELEPHONY_RINGTONE,

                 AUDIO_CONTENT_TYPE_UNKNOWN, group_id);
@@ -6608,6 +6651,7 @@ TEST_F(UnicastTest, NotifyAboutGroupTunrnedIdleDisabled) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_NOTIFICATION_TELEPHONY_RINGTONE,

                 AUDIO_CONTENT_TYPE_UNKNOWN, group_id);
@@ -6730,6 +6774,7 @@ TEST_F(UnicastTest, SpeakerStreamingTimeout) { 
  EXPECT_CALL(*mock_le_audio_source_hal_client_, Start(_, _)).Times(1);

  EXPECT_CALL(*mock_le_audio_sink_hal_client_, Start(_, _)).Times(1);

  LeAudioClient::Get()->GroupSetActive(group_id);

  SyncOnMainLoop();



  StartStreaming(AUDIO_USAGE_MEDIA, AUDIO_CONTENT_TYPE_MUSIC, group_id);