Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a268ecd6 authored by Pavlin Radoslavov's avatar Pavlin Radoslavov
Browse files

Perform all codec-related init operations on the same thread 

Renamed btif_a2dp_source_encoder_init_event() to
btif_a2dp_source_setup_codec_delayed() and moved the
peer parameter fetching from btif_a2dp_source_setup_codec()
to btif_a2dp_source_setup_codec_delayed()

Test: Manual - A2DP connect/disconnect; audio streaming
Change-Id: Ib29dd6b2bef3045be3727122e1f8608780921d98
parent 86eb8346

system/btif/src/btif_a2dp_source.cc

+34 −35
Original line number Diff line number Diff line
@@ -303,8 +303,7 @@ static void btif_a2dp_source_cleanup_delayed(void); 
static void btif_a2dp_source_audio_tx_start_event(void);

static void btif_a2dp_source_audio_tx_stop_event(void);

static void btif_a2dp_source_audio_tx_flush_event(void);

static void btif_a2dp_source_encoder_init_event(

    const tA2DP_ENCODER_INIT_PEER_PARAMS& peer_params,

static void btif_a2dp_source_setup_codec_delayed(

    const RawAddress& peer_address);

static void btif_a2dp_source_encoder_user_config_update_event(

    const RawAddress& peer_address,
@@ -491,46 +490,19 @@ void btif_a2dp_source_setup_codec(const RawAddress& peer_address) { 
  // we're using that in frame size calculations now.

  CHECK(CHAR_BIT == 8);



  tA2DP_ENCODER_INIT_PEER_PARAMS peer_params;

  bta_av_co_get_peer_params(peer_address, &peer_params);

  btif_a2dp_source_thread.DoInThread(

      FROM_HERE, base::Bind(&btif_a2dp_source_encoder_init_event, peer_params,

                            peer_address));

}



void btif_a2dp_source_start_audio_req(void) {

  LOG_INFO(LOG_TAG, "%s", __func__);



  btif_a2dp_source_thread.DoInThread(

      FROM_HERE, base::Bind(&btif_a2dp_source_audio_tx_start_event));

  btif_a2dp_source_cb.stats.Reset();

  // Assign session_start_us to 1 when time_get_os_boottime_us() is 0 to

  // indicate btif_a2dp_source_start_audio_req() has been called

  btif_a2dp_source_cb.stats.session_start_us = time_get_os_boottime_us();

  if (btif_a2dp_source_cb.stats.session_start_us == 0) {

    btif_a2dp_source_cb.stats.session_start_us = 1;

  }

  btif_a2dp_source_cb.stats.session_end_us = 0;

}



void btif_a2dp_source_stop_audio_req(void) {

  LOG_INFO(LOG_TAG, "%s", __func__);



  btif_a2dp_source_thread.DoInThread(

      FROM_HERE, base::Bind(&btif_a2dp_source_audio_tx_stop_event));



  btif_a2dp_source_cb.stats.session_end_us = time_get_os_boottime_us();

  btif_a2dp_source_update_metrics();

  btif_a2dp_source_accumulate_stats(&btif_a2dp_source_cb.stats,

                                    &btif_a2dp_source_cb.accumulated_stats);

      FROM_HERE,

      base::Bind(&btif_a2dp_source_setup_codec_delayed, peer_address));

}



static void btif_a2dp_source_encoder_init_event(

    const tA2DP_ENCODER_INIT_PEER_PARAMS& peer_params,

static void btif_a2dp_source_setup_codec_delayed(

    const RawAddress& peer_address) {

  LOG_INFO(LOG_TAG, "%s: peer_address=%s", __func__,

           peer_address.ToString().c_str());



  tA2DP_ENCODER_INIT_PEER_PARAMS peer_params;

  bta_av_co_get_peer_params(peer_address, &peer_params);



  if (!bta_av_co_set_active_peer(peer_address)) {

    LOG_ERROR(LOG_TAG, "%s: Cannot stream audio: cannot set active peer to %s",

              __func__, peer_address.ToString().c_str());
@@ -559,6 +531,33 @@ static void btif_a2dp_source_encoder_init_event( 
      btif_a2dp_source_cb.encoder_interface->get_encoder_interval_ms();

}



void btif_a2dp_source_start_audio_req(void) {

  LOG_INFO(LOG_TAG, "%s", __func__);



  btif_a2dp_source_thread.DoInThread(

      FROM_HERE, base::Bind(&btif_a2dp_source_audio_tx_start_event));

  btif_a2dp_source_cb.stats.Reset();

  // Assign session_start_us to 1 when time_get_os_boottime_us() is 0 to

  // indicate btif_a2dp_source_start_audio_req() has been called

  btif_a2dp_source_cb.stats.session_start_us = time_get_os_boottime_us();

  if (btif_a2dp_source_cb.stats.session_start_us == 0) {

    btif_a2dp_source_cb.stats.session_start_us = 1;

  }

  btif_a2dp_source_cb.stats.session_end_us = 0;

}



void btif_a2dp_source_stop_audio_req(void) {

  LOG_INFO(LOG_TAG, "%s", __func__);



  btif_a2dp_source_thread.DoInThread(

      FROM_HERE, base::Bind(&btif_a2dp_source_audio_tx_stop_event));



  btif_a2dp_source_cb.stats.session_end_us = time_get_os_boottime_us();

  btif_a2dp_source_update_metrics();

  btif_a2dp_source_accumulate_stats(&btif_a2dp_source_cb.stats,

                                    &btif_a2dp_source_cb.accumulated_stats);

}



void btif_a2dp_source_encoder_user_config_update_req(

    const RawAddress& peer_address,

    const btav_a2dp_codec_config_t& codec_user_config) {