Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98327037 authored by Myles Watson's avatar Myles Watson
Browse files

bt_target.h: Remove always TRUE BTM_EIR_DEFAULT_FEC_REQUIRED 

Bug: 327390105
Test: mma -j32
Flag: EXEMPT, build-only change
Change-Id: Icfd4a3d2800fabc1f26079acfc6d394d14577d98
parent 24d4338d

system/bta/dm/bta_dm_act.cc

+0 −4
Original line number Diff line number Diff line
@@ -1074,11 +1074,7 @@ static void bta_dm_set_eir(char* local_name) { 
  uint8_t custom_uuid_idx;

#endif  // BTA_EIR_SERVER_NUM_CUSTOM_UUID

#endif  // BTA_EIR_CANNED_UUID_LIST

#if (BTM_EIR_DEFAULT_FEC_REQUIRED == FALSE)

  uint8_t free_eir_length = HCI_EXT_INQ_RESPONSE_LEN;

#else  // BTM_EIR_DEFAULT_FEC_REQUIRED

  uint8_t free_eir_length = HCI_DM5_PACKET_SIZE;

#endif  // BTM_EIR_DEFAULT_FEC_REQUIRED

  uint8_t num_uuid;

  uint8_t data_type;

  uint8_t local_name_len;

system/bta/dm/bta_dm_cfg.cc

+1 −9
Original line number Diff line number Diff line
@@ -614,7 +614,6 @@ const tBTM_PM_PWR_MD* p_bta_dm_pm_md = &bta_dm_pm_md[0]; 


/* The performance impact of EIR packet size

 *

 * When BTM_EIR_DEFAULT_FEC_REQUIRED is true,

 * 1 to 17 bytes,    DM1 is used and most robust.

 * 18 to 121 bytes,  DM3 is used but impacts inquiry scan time with large number

 *                    of devices.(almost double with 150 users)
@@ -622,13 +621,6 @@ const tBTM_PM_PWR_MD* p_bta_dm_pm_md = &bta_dm_pm_md[0]; 
 *                    small number of users. so it is not recommended.

 * 225 to 240 bytes, DH5 is used without FEC but it not recommended.

 *                    (same reason of DM5)

 *

 * When BTM_EIR_DEFAULT_FEC_REQUIRED is false,

 * 1 to 27 bytes,    DH1 is used but only robust at short range.

 * 28 to 183 bytes,  DH3 is used but only robust at short range and impacts

 * inquiry

 *                    scan time with large number of devices.

 * 184 to 240 bytes, DH5 is used but it not recommended.

 */



#if (BTA_EIR_CANNED_UUID_LIST == TRUE)

system/internal_include/bt_target.h

+0 −4
Original line number Diff line number Diff line
@@ -280,10 +280,6 @@ 
/******************************************

 *    Lisbon Features

 ******************************************/

/* This is set to TRUE if the FEC is required for EIR packet. */

#ifndef BTM_EIR_DEFAULT_FEC_REQUIRED

#define BTM_EIR_DEFAULT_FEC_REQUIRED TRUE

#endif



/* The IO capability of the local device (for Simple Pairing) */

#ifndef BTM_LOCAL_IO_CAPS

system/stack/btm/btm_inq.cc

+1 −1
Original line number Diff line number Diff line
@@ -2085,7 +2085,7 @@ void btm_inq_rmt_name_failed_cancelled(void) { 
tBTM_STATUS BTM_WriteEIR(BT_HDR* p_buff) {

  if (bluetooth::shim::GetController()->SupportsExtendedInquiryResponse()) {

    log::verbose("Write Extended Inquiry Response to controller");

    btsnd_hcic_write_ext_inquiry_response(p_buff, BTM_EIR_DEFAULT_FEC_REQUIRED);

    btsnd_hcic_write_ext_inquiry_response(p_buff, TRUE);

    return BTM_SUCCESS;

  } else {

    osi_free(p_buff);