Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98091a58 authored by Chris Manton's avatar Chris Manton
Browse files

IA2: Remove unused vars for gd code 

Bug: 302317771
Test: m .

Change-Id: I65e7756ec7de1f5cccfb7f8c6957bcfbc8829128
parent eb451f6d

system/gd/att/att_module.cc

+3 −3
Original line number Diff line number Diff line
@@ -33,12 +33,12 @@ const ModuleFactory AttModule::Factory = ModuleFactory([]() { return new AttModu 


namespace {

void OnAttRegistrationCompleteLe(

    l2cap::le::FixedChannelManager::RegistrationResult result,

    std::unique_ptr<l2cap::le::FixedChannelService> le_smp_service) {

    l2cap::le::FixedChannelManager::RegistrationResult /* result */,

    std::unique_ptr<l2cap::le::FixedChannelService> /* le_smp_service */) {

  LOG_INFO("ATT channel registration complete");

}



void OnAttConnectionOpenLe(std::unique_ptr<l2cap::le::FixedChannel> channel) {

void OnAttConnectionOpenLe(std::unique_ptr<l2cap::le::FixedChannel> /* channel */) {

  LOG_INFO("ATT conneciton opened");

}

}  // namespace

system/gd/common/audit_log.cc

+4 −1
Original line number Diff line number Diff line
@@ -33,7 +33,10 @@ constexpr int SEC_TAG_BLUETOOTH_CONNECTION = 210039; 
namespace bluetooth {

namespace common {



void LogConnectionAdminAuditEvent(const char* action, const hci::Address& address, hci::ErrorCode status) {

void LogConnectionAdminAuditEvent(

    [[maybe_unused]] const char* action,

    [[maybe_unused]] const hci::Address& address,

    [[maybe_unused]] hci::ErrorCode status) {

#if defined(__ANDROID__) && !defined (FUZZ_TARGET)



  android_log_event_list(SEC_TAG_BLUETOOTH_CONNECTION)

system/gd/dumpsys/filter.cc

+6 −4
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ class Filter { 
   *

   * @return true if field was filtered successfully, false otherwise.

   */

  virtual bool FilterField(const reflection::Field* field, flatbuffers::Table* table) {

  virtual bool FilterField(const reflection::Field* /* field */, flatbuffers::Table* /* table */) {

    return false;

  }
@@ -62,7 +62,8 @@ class Filter { 
   * @param table The populated field data, if any

   *

   */

  virtual void FilterObject(const reflection::Object* object, flatbuffers::Table* table){};

  virtual void FilterObject(

      const reflection::Object* /* object */, flatbuffers::Table* /* table */){};



  /**

   * Given both reflection field data and the populated table data, if any,
@@ -72,7 +73,8 @@ class Filter { 
   * @param table The populated field data, if any

   *

   */

  virtual void FilterTable(const reflection::Schema* schema, flatbuffers::Table* table){};

  virtual void FilterTable(

      const reflection::Schema* /* schema */, flatbuffers::Table* /* table */){};



  const dumpsys::ReflectionSchema& reflection_schema_;

};
@@ -80,7 +82,7 @@ class Filter { 
class DeveloperPrivacyFilter : public Filter {

 public:

  DeveloperPrivacyFilter(const dumpsys::ReflectionSchema& reflection_schema) : Filter(reflection_schema) {}

  void FilterInPlace(char* dumpsys_data) override { /* Nothing to do in this mode */

  void FilterInPlace(char* /* dumpsys_data */) override { /* Nothing to do in this mode */

  }

};

system/gd/hal/hci_hal_android_hidl.cc

+1 −1
Original line number Diff line number Diff line
@@ -384,7 +384,7 @@ class HciHalHidl : public HciHal { 
    if (aidl_hci_ != nullptr) {

      LOG_INFO("Using the AIDL interface");

      aidl_death_recipient_ =

          ::ndk::ScopedAIBinder_DeathRecipient(AIBinder_DeathRecipient_new([](void* cookie) {

          ::ndk::ScopedAIBinder_DeathRecipient(AIBinder_DeathRecipient_new([](void* /* cookie*/) {

            LOG_ERROR("The Bluetooth HAL service died. Dumping logs and crashing in 1 second.");

            common::StopWatch::DumpStopWatchLog();

            // At shutdown, sometimes the HAL service gets killed before Bluetooth.

system/gd/hal/snoop_logger.cc

+3 −2
Original line number Diff line number Diff line
@@ -643,7 +643,8 @@ bool SnoopLogger::ShouldFilterLog(bool is_received, uint8_t* packet) { 
  return false;

}



void SnoopLogger::CalculateAclPacketLength(uint32_t& length, uint8_t* packet, bool is_received) {

void SnoopLogger::CalculateAclPacketLength(

    uint32_t& length, uint8_t* packet, bool /* is_received */) {

  uint32_t def_len =

      ((((uint16_t)packet[ACL_LENGTH_OFFSET + 1]) << 8) + packet[ACL_LENGTH_OFFSET]) +

      ACL_HEADER_LENGTH + PACKET_TYPE_LENGTH;
@@ -1309,7 +1310,7 @@ void SnoopLogger::DumpSnoozLogToFile(const std::vector<std::string>& data) const 
  }

}



void SnoopLogger::ListDependencies(ModuleList* list) const {

void SnoopLogger::ListDependencies(ModuleList* /* list */) const {

  // We have no dependencies

}