Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 95ced0c7 authored by David Srbecky's avatar David Srbecky Committed by Gerrit Code Review
Browse files

Revert "Run GTests with ASAN on 32bit only" 

Revert submission 2508278

Reason for revert: Breaks many builds

Reverted changes: /q/submissionid:2508278

Bug: 275453018
Change-Id: I56ecc1cae61b19f052b707beab55ce4590eaa8f8
parent 13387158

Android.bp

+0 −24
Original line number Diff line number Diff line
@@ -67,27 +67,3 @@ filegroup { 
        "AndroidTestTemplate.xml",

    ],

}
 


filegroup {

    name: "BluetoothGTestForce32ConfigTemplate",

    srcs: [

        "AndroidGTestForce32Template.xml",

    ],

}



// Address Sanitizer is flaky on Android x86_64 binaries but it's not on x86

// binaries.

// This default workaround the x86_64 ASAN flakyness by running 32bit binaries

// on 64bit targets.

// TODO(b/154347133): Remove this workaround

cc_defaults {

    name: "bluetooth_gtest_x86_asan_workaround",

    target: {

        android_x86: {

            test_config_template: ":BluetoothGTestForce32ConfigTemplate",

        },

        android_x86_64: {

            enabled: false,

        },

    },

}

AndroidGTestForce32Template.xml

deleted100644 → 0
+0 −44
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!-- Copyright (C) 2023 The Android Open Source Project



     Licensed under the Apache License, Version 2.0 (the "License");

     you may not use this file except in compliance with the License.

     You may obtain a copy of the License at



          http://www.apache.org/licenses/LICENSE-2.0



     Unless required by applicable law or agreed to in writing, software

     distributed under the License is distributed on an "AS IS" BASIS,

     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

     See the License for the specific language governing permissions and

     limitations under the License.

-->

<configuration description="Runs {MODULE}.">

  <option name="test-suite-tag" value="apct" />

  <option name="test-suite-tag" value="apct-native" />

  <target_preparer class="com.android.tradefed.targetprep.RootTargetPreparer" />

  <target_preparer class="com.android.compatibility.common.tradefed.targetprep.FilePusher">

        <option name="cleanup" value="true" />

        <option name="push" value="{MODULE}32->/data/local/tmp/{MODULE}" />

    </target_preparer>

  <target_preparer class="com.android.tradefed.targetprep.RunCommandTargetPreparer">

    <option name="run-command" value="settings put global ble_scan_always_enabled 0" />

    <option name="run-command" value="cmd bluetooth_manager disable" />

    <option name="run-command" value="cmd bluetooth_manager wait-for-state:STATE_OFF" />

  </target_preparer>

  <target_preparer class="com.android.tradefed.targetprep.FolderSaver">

    <option name="device-path" value="/data/vendor/ssrdump" />

  </target_preparer>

  <test class="com.android.tradefed.testtype.GTest" >

    <option name="native-test-device-path" value="/data/local/tmp" />

    <option name="module-name" value="{MODULE}" />

    <option name="run-test-as" value="0" />

  </test>



  <!-- Only run tests in MTS if the Bluetooth Mainline module is installed. -->

  <object type="module_controller"

          class="com.android.tradefed.testtype.suite.module.MainlineTestModuleController">

      <option name="mainline-module-package-name" value="com.android.btservices" />

      <option name="mainline-module-package-name" value="com.google.android.btservices" />

  </object>

</configuration>

system/audio_a2dp_hw/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -61,7 +61,6 @@ cc_test { 
    defaults: [

        "audio_a2dp_hw_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    srcs: [

        "test/audio_a2dp_hw_test.cc",

system/audio_hearing_aid_hw/Android.bp

+0 −1
Original line number Diff line number Diff line
@@ -43,7 +43,6 @@ cc_test { 
    defaults: [

        "audio_hearing_aid_hw_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    srcs: [

        "test/audio_hearing_aid_hw_test.cc",

system/bta/Android.bp

+0 −11
Original line number Diff line number Diff line
@@ -187,7 +187,6 @@ cc_test { 
    defaults: [

        "fluoride_bta_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    test_suites: ["device-tests"],

    srcs: [
@@ -234,7 +233,6 @@ cc_test { 
    defaults: [

        "fluoride_bta_defaults",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    test_suites: ["device-tests"],

    host_supported: true,
@@ -327,7 +325,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -382,7 +379,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -425,7 +421,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -545,7 +540,6 @@ cc_test { 
        "fluoride_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    target: {
@@ -634,7 +628,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -728,7 +721,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -780,7 +772,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    include_dirs: [
@@ -852,7 +843,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below
@@ -909,7 +899,6 @@ cc_test { 
        "fluoride_bta_defaults",

        "clang_coverage_bin",

        "mts_defaults",

        "bluetooth_gtest_x86_asan_workaround",

    ],

    host_supported: true,

    // TODO(b/231993739): Reenable isolated:true by deleting the explicit disable below