Merge "gd/common: Replace variable length array"

std::optional<bool> BoolFromString(const std::string& str);

std::string ToString(bool value);

// Migrate this method to std::format when C++20 becomes available

// printf like formatting to std::string

// format must contains format information, to print a string use StringFormat("%s", str)

template <typename... Args>

  auto size = std::snprintf(nullptr, 0, format.c_str(), args...);

  ASSERT_LOG(size >= 0, "return value %d, error %d, text '%s'", size, errno, strerror(errno));

  // Add 1 for terminating null byte

  char buffer[size + 1];

  auto actual_size = std::snprintf(buffer, sizeof(buffer), format.c_str(), args...);

  std::vector<char> buffer(size + 1);

  auto actual_size = std::snprintf(buffer.data(), buffer.size(), format.c_str(), args...);

  ASSERT_LOG(

      size == actual_size,

      "asked size %d, actual size %d, error %d, text '%s'",

      errno,

      strerror(errno));

  // Exclude the terminating null byte

  return std::string(buffer, size);

  return std::string(buffer.data(), size);

}

inline std::string StringFormatTime(const std::string& format, const struct std::tm& tm) {